Page MenuHomeFreeBSD
Differential D39799

pxeboot: bugs in pxe.h
ClosedPublic
Actions

Authored by tsoome on Apr 25 2023, 12:13 PM.
Tags
None
Referenced Files
F123688378: D39799.id.diff
Thu, Jul 17, 6:37 PM
Unknown Object (File)
Wed, Jul 16, 8:48 PM
Unknown Object (File)
Sun, Jul 13, 2:01 AM
Unknown Object (File)
Sat, Jul 12, 12:39 AM
Unknown Object (File)
Mon, Jul 7, 4:05 PM
Unknown Object (File)
Thu, Jul 3, 12:39 PM
Unknown Object (File)
Tue, Jul 1, 1:45 PM
Unknown Object (File)
Tue, Jul 1, 6:12 AM
View All 82 Files
Subscribers
dab
imp

Details

Reviewers
manu
imp
Commits
rG795497bf3d2c: pxeboot: bugs in pxe.h
Summary

SEGDESC_t needs to be PACKED
there is no status in t_PXENV_UNDI_MCAST_ADDRESS

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51175
Build 48066: arc lint + arc unit

Event Timeline

tsoome created this revision.Apr 25 2023, 12:13 PM
Herald added a reviewer: manu. · View Herald TranscriptApr 25 2023, 12:13 PM
Herald added subscribers: dab, imp. · View Herald Transcript
tsoome requested review of this revision.Apr 25 2023, 12:13 PM
Harbormaster completed remote builds in B51175: Diff 120997.Apr 25 2023, 12:13 PM
imp accepted this revision.Apr 25 2023, 10:42 PM

so how was all this working before?
or is SEGDESC_t not all that important?

This revision is now accepted and ready to land.Apr 25 2023, 10:42 PM
tsoome added a comment.Apr 25 2023, 10:43 PM
In D39799#906388, @imp wrote:

so how was all this working before?
or is SEGDESC_t not all that important?

We are not using those fields, nor support multicast.

Closed by commit rG795497bf3d2c: pxeboot: bugs in pxe.h (authored by tsoome). · Explain WhyApr 26 2023, 1:34 PM
This revision was automatically updated to reflect the committed changes.
tsoome added a commit: rG795497bf3d2c: pxeboot: bugs in pxe.h.

Revision Contents
Changeset List

PathSize
stand/
i386/
libi386/
3 lines

Diff 120997

View Options

stand/i386/libi386/pxe.h

Loading...