Differential D665

Add option helper for PLIST_SUB
ClosedPublic
Actions

Authored by antoine on Aug 21 2014, 2:12 PM.

Details

Reviewers

mat

Group Reviewers

portmgr

Commits

rP365573: Add an option helper for PLIST_SUB

Summary

Add option helper for PLIST_SUB
Suggested by koobs

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

antoine updated this revision to Diff 1198.Aug 21 2014, 2:12 PM

antoine retitled this revision from to Add option helper for PLIST_SUB.

antoine updated this object.

antoine edited the test plan for this revision. (Show Details)

antoine added a reviewer: koobs.

Herald added a reviewer: portmgr. · View Herald TranscriptAug 21 2014, 2:12 PM

This is super awesome, thanks for creating this @antoine!

Will help remove this kind of thing:

.if ${PORT_OPTIONS:MPYTHON}
PLIST_SUB+=     PYTHON_VER="${PYTHON_VER}" VERSION="${PORTVERSION}"
.endif

koobs accepted this revision.Aug 21 2014, 2:35 PM

koobs edited edge metadata.

mat accepted this revision.Aug 21 2014, 4:07 PM

mat added a reviewer: mat.

This revision is now accepted and ready to land.Aug 21 2014, 4:07 PM

Please, also add it to the porter's handbook, in head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml about line 4188 (and add INFO too, it kinda crept through.)

Mk/bsd.apache.mk:${module}_PLIST_SUB= "@comment "
Mk/bsd.apache.mk:${module}_PLIST_SUB= ""
Mk/bsd.apache.mk:PLIST_SUB+= MOD_${module}=${${module}_PLIST_SUB}
x11-themes/slim-themes/Makefile:NEW_PLIST_SUB:= ${PLIST_SUB} ${n}=""
x11-themes/slim-themes/Makefile:PLIST_SUB:= ${NEW_PLIST_SUB}
x11-themes/slim-themes/Makefile:NEW_PLIST_SUB:= ${PLIST_SUB} ${n}="@comment "
x11-themes/slim-themes/Makefile:PLIST_SUB:= ${NEW_PLIST_SUB}