Page MenuHomeFreeBSD
Differential D39554

linuxkpi: advance platform_device
ClosedPublic
Actions

Authored by corvink on Apr 13 2023, 7:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 18, 9:18 AM
Unknown Object (File)
Sat, Apr 18, 5:36 AM
Unknown Object (File)
Fri, Apr 17, 3:12 PM
Unknown Object (File)
Thu, Apr 9, 12:11 AM
Unknown Object (File)
Sun, Mar 22, 10:50 PM
Unknown Object (File)
Mar 20 2026, 3:35 AM
Unknown Object (File)
Mar 19 2026, 11:49 PM
Unknown Object (File)
Mar 19 2026, 4:40 AM
View All Files
Subscribers
bz
emaste
imp
linuxkpi

Details

Reviewers
manu
Commits
rG1fb7c59981bc: linuxkpi: advance platform_device
rG740d76544ad8: linuxkpi: advance platform_device
Summary

These are required by some linux driver like:
https://github.com/beckhoff/bbapi

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50883
Build 47774: arc lint + arc unit

Event Timeline

corvink created this revision.Apr 13 2023, 7:20 AM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptApr 13 2023, 7:20 AM
corvink requested review of this revision.Apr 13 2023, 7:20 AM
Harbormaster completed remote builds in B50883: Diff 120252.Apr 13 2023, 7:20 AM
manu accepted this revision.Apr 13 2023, 7:27 AM
This revision is now accepted and ready to land.Apr 13 2023, 7:27 AM
bz added a subscriber: bz.Apr 14 2023, 9:51 AM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/platform_device.h
87

Do we really want to return 0 in the case that it is not implemented rather than an error?

manu added inline comments.Apr 14 2023, 12:38 PM
sys/compat/linuxkpi/common/include/linux/platform_device.h
87

It's unlikely that we will one day implement those functions. Returning 0 is less problems than an error as the drivers who calls this will not fail.

Closed by commit rG740d76544ad8: linuxkpi: advance platform_device (authored by corvink). · Explain WhyJun 13 2023, 7:49 AM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG740d76544ad8: linuxkpi: advance platform_device.
corvink added a commit: rG1fb7c59981bc: linuxkpi: advance platform_device.Aug 17 2023, 1:29 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
9 lines

Diff 120252

View Options

sys/compat/linuxkpi/common/include/linux/platform_device.h

Loading...