Page MenuHomeFreeBSD
Differential D39383

pseudofs: Simplify pfs_visible_proc
ClosedPublic
Actions

Authored by dchagin on Apr 1 2023, 3:20 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Apr 26, 12:39 AM
Unknown Object (File)
Tue, Apr 14, 5:50 AM
Unknown Object (File)
Sat, Apr 11, 8:48 PM
Unknown Object (File)
Sat, Apr 11, 11:45 AM
Unknown Object (File)
Sat, Apr 11, 10:09 AM
Unknown Object (File)
Fri, Apr 10, 8:56 PM
Unknown Object (File)
Fri, Apr 10, 6:23 PM
Unknown Object (File)
Fri, Apr 10, 2:32 AM
View All Files
Subscribers
imp

Details

Reviewers
des
Group Reviewers
Linux Emulation
Commits
rGb73e978d7d17: pseudofs: Simplify pfs_visible_proc
rGa32ed5ec05d9: pseudofs: Simplify pfs_visible_proc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50723
Build 47614: arc lint + arc unit

Event Timeline

dchagin created this revision.Apr 1 2023, 3:20 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 1 2023, 3:20 PM
dchagin requested review of this revision.Apr 1 2023, 3:20 PM
Harbormaster completed remote builds in B50717: Diff 119746.Apr 1 2023, 3:20 PM
dchagin added reviewers: des, Linux Emulation.Apr 1 2023, 3:27 PM
dchagin added a project: Linux Emulation.
des added a comment.Apr 1 2023, 6:06 PM

Perhaps better to drop visible entirely:

if (proc->p_flag & P_WEXIT)
        return (0);
if (p_cansee(td, proc) != 0)
        return (0);
if (pn->pn_vis && pn_vis(td, proc, pn) == 0)
        return (0);
return (1);
des mentioned this in D39382: pseudofs: Allow vis callback to be called for a named node.Apr 1 2023, 6:19 PM
dchagin updated this revision to Diff 119758.Apr 1 2023, 8:29 PM

Done

Harbormaster completed remote builds in B50723: Diff 119758.Apr 1 2023, 8:29 PM
des accepted this revision.Apr 1 2023, 9:58 PM
This revision is now accepted and ready to land.Apr 1 2023, 9:58 PM
Closed by commit rGa32ed5ec05d9: pseudofs: Simplify pfs_visible_proc (authored by dchagin). · Explain WhyApr 2 2023, 8:25 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGa32ed5ec05d9: pseudofs: Simplify pfs_visible_proc.
dchagin added a commit: rGb73e978d7d17: pseudofs: Simplify pfs_visible_proc.Jun 29 2023, 8:20 AM

Revision Contents
Changeset List

PathSize
sys/
fs/
pseudofs/
12 lines

Diff 119758

View Options

sys/fs/pseudofs/pseudofs_vnops.c

Loading...