Page MenuHomeFreeBSD
Differential D39342

Add myself (cc) as a src commiter.
ClosedPublic
Actions

Authored by cc on Mar 30 2023, 3:28 PM.
Tags
None
Referenced Files
F87336647: D39342.id119680.diff
Mon, Jul 1, 9:03 PM
F87336578: D39342.id119679.diff
Mon, Jul 1, 9:02 PM
F87336270: D39342.id119697.diff
Mon, Jul 1, 8:59 PM
F87334883: D39342.id119670.diff
Mon, Jul 1, 8:45 PM
Unknown Object (File)
Sat, Jun 29, 6:23 PM
Unknown Object (File)
Sat, Jun 29, 8:58 AM
Unknown Object (File)
Sat, Jun 29, 8:58 AM
Unknown Object (File)
Sun, Jun 23, 10:29 AM
View All 53 Files
Subscribers
imp

Details

Reviewers
rscheff
tuexen
Commits
rG134ced89c4ca: Add myself (cc) as a src commiter.
Summary

Adding mentor relationships for cc when committing new diffs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50679
Build 47570: arc lint + arc unit

Event Timeline

cc created this revision.Mar 30 2023, 3:28 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 30 2023, 3:28 PM
cc requested review of this revision.Mar 30 2023, 3:28 PM
Harbormaster completed remote builds in B50679: Diff 119670.Mar 30 2023, 3:28 PM
tuexen added inline comments.Mar 30 2023, 3:47 PM
share/misc/committers-src.dot
927

In most of the cases, the entries with the same mentor are alphabetically sorted by the mentees. So I suggest to put tuexen -> cc before tuexen -> rscheff.

rscheff requested changes to this revision.Mar 30 2023, 4:21 PM

Yes, the entries should be sorted by mentor (1st), mentee (2nd).

Apparently it does get sorted from time to time, but keeping it in order is good style.

This revision now requires changes to proceed.Mar 30 2023, 4:21 PM
cc updated this revision to Diff 119679.Mar 30 2023, 7:54 PM

Update based on reviewers' comments.

Harbormaster completed remote builds in B50682: Diff 119679.Mar 30 2023, 7:54 PM
cc updated this revision to Diff 119680.Mar 30 2023, 7:58 PM

Update details.

Harbormaster completed remote builds in B50683: Diff 119680.Mar 30 2023, 7:58 PM
tuexen accepted this revision.Mar 30 2023, 8:23 PM
rscheff accepted this revision.Mar 30 2023, 10:13 PM
This revision is now accepted and ready to land.Mar 30 2023, 10:13 PM
Closed by commit rG134ced89c4ca: Add myself (cc) as a src commiter. (authored by cc). · Explain WhyMar 31 2023, 12:27 AM
This revision was automatically updated to reflect the committed changes.
cc added a commit: rG134ced89c4ca: Add myself (cc) as a src commiter..
cc added a reverting change: D39363: Revert "Add myself (cc) as a src commiter.".Mar 31 2023, 10:56 AM
cc added a reverting change: rGfcad8ada9afc: Revert "Add myself (cc) as a src commiter.".Mar 31 2023, 1:59 PM

Revision Contents
Changeset List

PathSize
share/
misc/
4 lines

Diff 119670

View Options

share/misc/committers-src.dot

Loading...