makefs: correct El Torito bood record
ClosedPublic
Actions

Authored by emaste on Mar 23 2023, 5:08 PM.

Details

Reviewers

jrtc27
kevans

Commits

rGb95746135307: makefs: correct El Torito bood record
rG9f2a52536047: makefs: correct El Torito bood record

Summary

The boot catalog pointer is a DWord, but we previously populated it via cd9660_bothendian_dword which overwrote four unused bytes following it. See El Torito 1.0 (1995) Figure 7 for details.

PR: 203531
Reported by: Coverity Scan
Reported by: Thomas Schmitt <scdbackup@gmx.net>
CID: 977470
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

A link to the El Torito doc is available from https://wiki.osdev.org/El-Torito

emaste added reviewers: jrtc27, kevans.Mar 23 2023, 5:29 PM

This matches my reading of the spec; single LE DWORD.

This revision is now accepted and ready to land.Mar 23 2023, 9:33 PM

Closed by commit rG9f2a52536047: makefs: correct El Torito bood record (authored by emaste). · Explain WhyMar 23 2023, 9:57 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG9f2a52536047: makefs: correct El Torito bood record.

Herald added a subscriber: imp. · View Herald TranscriptMar 23 2023, 9:57 PM

emaste added a commit: rGb95746135307: makefs: correct El Torito bood record.Apr 10 2023, 1:39 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

makefs/

cd9660/

cd9660_eltorito.c

4 lines

Diff 119360

View Options

usr.sbin/makefs/cd9660/cd9660_eltorito.c

makefs: correct El Torito bood recordClosedPublicActions