Page MenuHomeFreeBSD

devel/gdb: Remove the EXPAT option.
ClosedPublic

Authored by jhb on Feb 24 2023, 6:12 PM.
Tags
None
Referenced Files
F103916974: D38760.id118770.diff
Sun, Dec 1, 4:41 AM
F103916699: D38760.id119035.diff
Sun, Dec 1, 4:35 AM
F103911574: D38760.diff
Sun, Dec 1, 2:43 AM
Unknown Object (File)
Thu, Nov 14, 11:01 AM
Unknown Object (File)
Wed, Nov 13, 2:35 AM
Unknown Object (File)
Tue, Nov 5, 9:10 PM
Unknown Object (File)
Sat, Nov 2, 9:02 AM
Unknown Object (File)
Oct 6 2024, 10:44 AM
Subscribers

Details

Summary

GDB on FreeBSD requires libxml for full funtionality (e.g. 'catch
syscall <syscall name>' parses the XML files installed in
LOCALBASE/share that were still installed even when this option was
disabled). Also, using GDB with a debug server that returns any
non-simple registers requires XML support for parsing the target
description returned by the server (e.g. examining SSE or later
registers or any system registers when attached to QEMU or
lldb-server).

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 24 2023, 6:12 PM
danfe requested changes to this revision.Feb 25 2023, 7:49 AM
danfe added inline comments.
devel/gdb/Makefile
31

Are these two needed? I recall it was autodetected properly once installed. We typically don't reinforce (reiterate) options which match default behavior.

37

Please add the entry to existing LIB_DEPENDS above (keeping it properly sorted) rathen than amending it in the middle of the Makefile.

This revision now requires changes to proceed.Feb 25 2023, 7:49 AM

Add review feedback from danfe@.

jhb marked 2 inline comments as done.Feb 28 2023, 1:41 AM

Thanks for fixing the libraries' order in LIB_DEPENDS John, this is good to go now.

This revision is now accepted and ready to land.Mar 14 2023, 2:16 AM
This revision was automatically updated to reflect the committed changes.