Page MenuHomeFreeBSD

devel/gdb: Remove the EXPAT option.
ClosedPublic

Authored by jhb on Feb 24 2023, 6:12 PM.
Tags
None
Referenced Files
F166918916: D38760.diff
Mon, Aug 17, 6:35 PM
Unknown Object (File)
Sat, Aug 8, 5:27 PM
Unknown Object (File)
Mon, Jul 27, 2:40 AM
Unknown Object (File)
Thu, Jul 23, 7:30 AM
Unknown Object (File)
Wed, Jul 22, 5:43 PM
Unknown Object (File)
Tue, Jul 21, 4:06 PM
Unknown Object (File)
Tue, Jul 21, 6:07 AM
Unknown Object (File)
Mon, Jul 20, 1:35 PM
Subscribers

Details

Summary

GDB on FreeBSD requires libxml for full funtionality (e.g. 'catch
syscall <syscall name>' parses the XML files installed in
LOCALBASE/share that were still installed even when this option was
disabled). Also, using GDB with a debug server that returns any
non-simple registers requires XML support for parsing the target
description returned by the server (e.g. examining SSE or later
registers or any system registers when attached to QEMU or
lldb-server).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50054
Build 46946: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Feb 24 2023, 6:12 PM
danfe requested changes to this revision.Feb 25 2023, 7:49 AM
danfe added inline comments.
devel/gdb/Makefile
30

Are these two needed? I recall it was autodetected properly once installed. We typically don't reinforce (reiterate) options which match default behavior.

36

Please add the entry to existing LIB_DEPENDS above (keeping it properly sorted) rathen than amending it in the middle of the Makefile.

This revision now requires changes to proceed.Feb 25 2023, 7:49 AM

Add review feedback from danfe@.

jhb marked 2 inline comments as done.Feb 28 2023, 1:41 AM

Thanks for fixing the libraries' order in LIB_DEPENDS John, this is good to go now.

This revision is now accepted and ready to land.Mar 14 2023, 2:16 AM
This revision was automatically updated to reflect the committed changes.