Differential D38759

devel/gdb: Upgrade to 13.1.
ClosedPublic
Actions

Authored by jhb on Feb 24 2023, 6:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 19, 11:26 AM

	Unknown Object (File)
	Mon, Mar 17, 4:24 PM

	Unknown Object (File)
	Fri, Mar 14, 8:05 AM

	Unknown Object (File)
	Sat, Mar 1, 10:46 PM

	Unknown Object (File)
	Mon, Feb 24, 8:33 AM

	Unknown Object (File)
	Feb 13 2025, 5:06 AM

	Unknown Object (File)
	Feb 9 2025, 7:15 AM

	Unknown Object (File)
	Feb 8 2025, 9:22 PM

View All 87 Files

Subscribers

Details

Reviewers

Commits

R11:27ee37af5635: devel/gdb: Upgrade to 13.1.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50342
Build 47234: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 24 2023, 6:11 PM

Herald added subscribers: mat, emaste, andrew. · View Herald TranscriptFeb 24 2023, 6:11 PM

jhb requested review of this revision.Feb 24 2023, 6:11 PM

Harbormaster completed remote builds in B49993: Diff 117884.Feb 24 2023, 6:11 PM

Given https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268994 we probably want to make sure zstd from ports gets pulled into gdb?

Add zstd and a backported patch

Harbormaster completed remote builds in B50342: Diff 118769.Mar 13 2023, 9:22 PM

The backported patch (which is from gdb-13-branch and will be in 13.2) fixes the build if you are building the port on a system with devel/binutils installed.

pizzamig accepted this revision.Mar 16 2023, 4:14 PM

This revision is now accepted and ready to land.Mar 16 2023, 4:14 PM

Closed by commit R11:27ee37af5635: devel/gdb: Upgrade to 13.1. (authored by jhb). · Explain WhyMar 17 2023, 11:48 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: R11:27ee37af5635: devel/gdb: Upgrade to 13.1..

Revision Contents
Changeset List

Path

Size

devel/

gdb/

36 lines

6 lines

files/

commit-041a4212d37

commit-065a00b3a46

commit-099fbce0acc

commit-0a765c1a8e9

commit-1570c37c340

commit-2e686a74dc4

commit-3181aed81c9

commit-40c23d88038

commit-414d5848bb2

commit-4bd817e71ee

commit-6719bc690e2

commit-684943d213b

commit-711b0b6698f

commit-8e6afe4013f

commit-922c2fc18e4

commit-92d48a1e4ea

commit-983b1119bc3

commit-a171378aa47

commit-a3627b54280

commit-a49ce729c80

commit-a980a7d24b9

37 lines

commit-b1babce7c31

commit-b2fdd31b03e

commit-b5c2367c3ac

commit-b7fe5463cf0

commit-c13566fdd57

commit-c77282d8ba9

commit-e330d4c033e

commit-f3215e1526d

commit-f9fbb7636a5

extrapatch-kgdb

164 lines

kgdb/

aarch64-fbsd-kern.c

21 lines

amd64fbsd-kern.c

10 lines

arm-fbsd-kern.c

18 lines

24 lines

4 lines

119 lines

i386fbsd-kern.c

51 lines

mipsfbsd-kern.c

22 lines

22 lines

riscv-fbsd-kern.c

16 lines

sparc64fbsd-kern.c

10 lines

patch-gdb-completer.c

patch-gnulib_import_stddef.in.h

10 lines

2 lines

Diff 118769

devel/gdb/Makefile

	Show First 20 Lines • Show All 745 Lines • ▼ Show 20 Lines		default:
	lsi->lsi_int = si->si_value.sival_int;			lsi->lsi_int = si->si_value.sival_int;
	lsi->lsi_ptr = PTROUT(si->si_value.sival_ptr);			lsi->lsi_ptr = PTROUT(si->si_value.sival_ptr);
	}			}
	break;			break;
	}			}
	break;			break;
	}			}
	}			}

				void
				lsiginfo_to_ksiginfo(const l_siginfo_t lsi, ksiginfo_t ksi, int sig)
				{

				ksi->ksi_signo = sig;
				ksi->ksi_code = lsi->lsi_code;
				dchaginAuthorUnsubmitted Not Done Inline Actions Linux allows SI_ here. So, I plan to convert this later. dchagin: Linux allows SI_ here. So, I plan to convert this later.
				ksi->ksi_pid = lsi->lsi_pid;
				ksi->ksi_uid = lsi->lsi_uid;
				ksi->ksi_status = lsi->lsi_status;
				ksi->ksi_addr = PTRIN(lsi->lsi_addr);
				ksi->ksi_info.si_value.sival_int = lsi->lsi_int;
				}

				int
				linux_rt_sigqueueinfo(struct thread td, struct linux_rt_sigqueueinfo_args args)
				{
				l_siginfo_t linfo;
				struct proc *p;
				ksiginfo_t ksi;
				int error;
				int sig;

				if (!LINUX_SIG_VALID(args->sig))
				return (EINVAL);

				error = copyin(args->info, &linfo, sizeof(linfo));
				if (error != 0)
				return (error);

				if (linfo.lsi_code >= 0)
				return (EPERM);

				if (args->sig > 0 && args->sig <= LINUX_SIGTBLSZ)
				sig = linux_to_bsd_signal[_SIG_IDX(args->sig)];
				else
				emasteUnsubmitted Not Done Inline Actions Should we log and/or disallow this case? emaste: Should we log and/or disallow this case?
				dchaginAuthorUnsubmitted Not Done Inline Actions No, RT signals. LINUX_SIG_VALID (707-708) validate user supplied sigcode. dchagin: No, RT signals. LINUX_SIG_VALID (707-708) validate user supplied sigcode.
				sig = args->sig;

				error = ESRCH;
				if ((p = pfind(args->pid)) != NULL \|\|
				(p = zpfind(args->pid)) != NULL) {
				ksiginfo_init(&ksi);
				traszUnsubmitted Not Done Inline Actions I think you're missing a lot of access checks here. See sys/kern/kern_sig:sys_kill(); in particular the IN_CAPABILITY_MODE() and p_cansignal(). trasz: I think you're missing a lot of access checks here. See sys/kern/kern_sig:sys_kill(); in…
				traszUnsubmitted Not Done Inline Actions Erm, ignore the IN_CAPABILITY_MODE(), but p_cansignal() should still be used, no? trasz: Erm, ignore the IN_CAPABILITY_MODE(), but p_cansignal() should still be used, no?
				lsiginfo_to_ksiginfo(&linfo, &ksi, sig);
				error = tdsendsignal(p, NULL, sig, &ksi);
				PROC_UNLOCK(p);
				}
				return (error);
				}

devel/gdb/distinfo

	Show First 20 Lines • Show All 745 Lines • ▼ Show 20 Lines		default:
	lsi->lsi_int = si->si_value.sival_int;			lsi->lsi_int = si->si_value.sival_int;
	lsi->lsi_ptr = PTROUT(si->si_value.sival_ptr);			lsi->lsi_ptr = PTROUT(si->si_value.sival_ptr);
	}			}
	break;			break;
	}			}
	break;			break;
	}			}
	}			}

				void
				lsiginfo_to_ksiginfo(const l_siginfo_t lsi, ksiginfo_t ksi, int sig)
				{

				ksi->ksi_signo = sig;
				ksi->ksi_code = lsi->lsi_code;
				dchaginAuthorUnsubmitted Not Done Inline Actions Linux allows SI_ here. So, I plan to convert this later. dchagin: Linux allows SI_ here. So, I plan to convert this later.
				ksi->ksi_pid = lsi->lsi_pid;
				ksi->ksi_uid = lsi->lsi_uid;
				ksi->ksi_status = lsi->lsi_status;
				ksi->ksi_addr = PTRIN(lsi->lsi_addr);
				ksi->ksi_info.si_value.sival_int = lsi->lsi_int;
				}

				int
				linux_rt_sigqueueinfo(struct thread td, struct linux_rt_sigqueueinfo_args args)
				{
				l_siginfo_t linfo;
				struct proc *p;
				ksiginfo_t ksi;
				int error;
				int sig;

				if (!LINUX_SIG_VALID(args->sig))
				return (EINVAL);

				error = copyin(args->info, &linfo, sizeof(linfo));
				if (error != 0)
				return (error);

				if (linfo.lsi_code >= 0)
				return (EPERM);

				if (args->sig > 0 && args->sig <= LINUX_SIGTBLSZ)
				sig = linux_to_bsd_signal[_SIG_IDX(args->sig)];
				else
				emasteUnsubmitted Not Done Inline Actions Should we log and/or disallow this case? emaste: Should we log and/or disallow this case?
				dchaginAuthorUnsubmitted Not Done Inline Actions No, RT signals. LINUX_SIG_VALID (707-708) validate user supplied sigcode. dchagin: No, RT signals. LINUX_SIG_VALID (707-708) validate user supplied sigcode.
				sig = args->sig;

				error = ESRCH;
				if ((p = pfind(args->pid)) != NULL \|\|
				(p = zpfind(args->pid)) != NULL) {
				ksiginfo_init(&ksi);
				traszUnsubmitted Not Done Inline Actions I think you're missing a lot of access checks here. See sys/kern/kern_sig:sys_kill(); in particular the IN_CAPABILITY_MODE() and p_cansignal(). trasz: I think you're missing a lot of access checks here. See sys/kern/kern_sig:sys_kill(); in…
				traszUnsubmitted Not Done Inline Actions Erm, ignore the IN_CAPABILITY_MODE(), but p_cansignal() should still be used, no? trasz: Erm, ignore the IN_CAPABILITY_MODE(), but p_cansignal() should still be used, no?
				lsiginfo_to_ksiginfo(&linfo, &ksi, sig);
				error = tdsendsignal(p, NULL, sig, &ksi);
				PROC_UNLOCK(p);
				}
				return (error);
				}

devel/gdb/files/commit-041a4212d37

	Show First 20 Lines • Show All 745 Lines • ▼ Show 20 Lines		default:
	lsi->lsi_int = si->si_value.sival_int;			lsi->lsi_int = si->si_value.sival_int;
	lsi->lsi_ptr = PTROUT(si->si_value.sival_ptr);			lsi->lsi_ptr = PTROUT(si->si_value.sival_ptr);
	}			}
	break;			break;
	}			}
	break;			break;
	}			}
	}			}

				void
				lsiginfo_to_ksiginfo(const l_siginfo_t lsi, ksiginfo_t ksi, int sig)
				{

				ksi->ksi_signo = sig;
				ksi->ksi_code = lsi->lsi_code;
				dchaginAuthorUnsubmitted Not Done Inline Actions Linux allows SI_ here. So, I plan to convert this later. dchagin: Linux allows SI_ here. So, I plan to convert this later.
				ksi->ksi_pid = lsi->lsi_pid;
				ksi->ksi_uid = lsi->lsi_uid;
				ksi->ksi_status = lsi->lsi_status;
				ksi->ksi_addr = PTRIN(lsi->lsi_addr);
				ksi->ksi_info.si_value.sival_int = lsi->lsi_int;
				}

				int
				linux_rt_sigqueueinfo(struct thread td, struct linux_rt_sigqueueinfo_args args)
				{
				l_siginfo_t linfo;
				struct proc *p;
				ksiginfo_t ksi;
				int error;
				int sig;

				if (!LINUX_SIG_VALID(args->sig))
				return (EINVAL);

				error = copyin(args->info, &linfo, sizeof(linfo));
				if (error != 0)
				return (error);

				if (linfo.lsi_code >= 0)
				return (EPERM);

				if (args->sig > 0 && args->sig <= LINUX_SIGTBLSZ)
				sig = linux_to_bsd_signal[_SIG_IDX(args->sig)];
				else
				emasteUnsubmitted Not Done Inline Actions Should we log and/or disallow this case? emaste: Should we log and/or disallow this case?
				dchaginAuthorUnsubmitted Not Done Inline Actions No, RT signals. LINUX_SIG_VALID (707-708) validate user supplied sigcode. dchagin: No, RT signals. LINUX_SIG_VALID (707-708) validate user supplied sigcode.
				sig = args->sig;

				error = ESRCH;
				if ((p = pfind(args->pid)) != NULL \|\|
				(p = zpfind(args->pid)) != NULL) {
				ksiginfo_init(&ksi);
				traszUnsubmitted Not Done Inline Actions I think you're missing a lot of access checks here. See sys/kern/kern_sig:sys_kill(); in particular the IN_CAPABILITY_MODE() and p_cansignal(). trasz: I think you're missing a lot of access checks here. See sys/kern/kern_sig:sys_kill(); in…
				traszUnsubmitted Not Done Inline Actions Erm, ignore the IN_CAPABILITY_MODE(), but p_cansignal() should still be used, no? trasz: Erm, ignore the IN_CAPABILITY_MODE(), but p_cansignal() should still be used, no?
				lsiginfo_to_ksiginfo(&linfo, &ksi, sig);
				error = tdsendsignal(p, NULL, sig, &ksi);
				PROC_UNLOCK(p);
				}
				return (error);
				}

devel/gdb/files/commit-065a00b3a46

	Show First 20 Lines • Show All 745 Lines • ▼ Show 20 Lines		default:
	lsi->lsi_int = si->si_value.sival_int;			lsi->lsi_int = si->si_value.sival_int;
	lsi->lsi_ptr = PTROUT(si->si_value.sival_ptr);			lsi->lsi_ptr = PTROUT(si->si_value.sival_ptr);
	}			}
	break;			break;
	}			}
	break;			break;
	}			}
	}			}

				void
				lsiginfo_to_ksiginfo(const l_siginfo_t lsi, ksiginfo_t ksi, int sig)
				{

				ksi->ksi_signo = sig;
				ksi->ksi_code = lsi->lsi_code;
				dchaginAuthorUnsubmitted Not Done Inline Actions Linux allows SI_ here. So, I plan to convert this later. dchagin: Linux allows SI_ here. So, I plan to convert this later.
				ksi->ksi_pid = lsi->lsi_pid;
				ksi->ksi_uid = lsi->lsi_uid;
				ksi->ksi_status = lsi->lsi_status;
				ksi->ksi_addr = PTRIN(lsi->lsi_addr);
				ksi->ksi_info.si_value.sival_int = lsi->lsi_int;
				}

				int
				linux_rt_sigqueueinfo(struct thread td, struct linux_rt_sigqueueinfo_args args)
				{
				l_siginfo_t linfo;
				struct proc *p;
				ksiginfo_t ksi;
				int error;
				int sig;

				if (!LINUX_SIG_VALID(args->sig))
				return (EINVAL);

				error = copyin(args->info, &linfo, sizeof(linfo));
				if (error != 0)
				return (error);

				if (linfo.lsi_code >= 0)
				return (EPERM);

				if (args->sig > 0 && args->sig <= LINUX_SIGTBLSZ)
				sig = linux_to_bsd_signal[_SIG_IDX(args->sig)];
				else
				emasteUnsubmitted Not Done Inline Actions Should we log and/or disallow this case? emaste: Should we log and/or disallow this case?
				dchaginAuthorUnsubmitted Not Done Inline Actions No, RT signals. LINUX_SIG_VALID (707-708) validate user supplied sigcode. dchagin: No, RT signals. LINUX_SIG_VALID (707-708) validate user supplied sigcode.
				sig = args->sig;

				error = ESRCH;
				if ((p = pfind(args->pid)) != NULL \|\|
				(p = zpfind(args->pid)) != NULL) {
				ksiginfo_init(&ksi);
				traszUnsubmitted Not Done Inline Actions I think you're missing a lot of access checks here. See sys/kern/kern_sig:sys_kill(); in particular the IN_CAPABILITY_MODE() and p_cansignal(). trasz: I think you're missing a lot of access checks here. See sys/kern/kern_sig:sys_kill(); in…
				traszUnsubmitted Not Done Inline Actions Erm, ignore the IN_CAPABILITY_MODE(), but p_cansignal() should still be used, no? trasz: Erm, ignore the IN_CAPABILITY_MODE(), but p_cansignal() should still be used, no?
				lsiginfo_to_ksiginfo(&linfo, &ksi, sig);
				error = tdsendsignal(p, NULL, sig, &ksi);
				PROC_UNLOCK(p);
				}
				return (error);
				}

devel/gdb/files/commit-099fbce0acc

Loading...

devel/gdb/files/commit-0a765c1a8e9

Loading...

devel/gdb/files/commit-1570c37c340

Loading...

devel/gdb/files/commit-2e686a74dc4

Loading...

devel/gdb/files/commit-3181aed81c9

Loading...

devel/gdb/files/commit-40c23d88038

Loading...

devel/gdb/files/commit-414d5848bb2

Loading...

devel/gdb/files/commit-4bd817e71ee

Loading...

devel/gdb/files/commit-6719bc690e2

Loading...

devel/gdb/files/commit-684943d213b

Loading...

devel/gdb/files/commit-711b0b6698f

Loading...

devel/gdb/files/commit-8e6afe4013f

Loading...

devel/gdb/files/commit-922c2fc18e4

Loading...

devel/gdb/files/commit-92d48a1e4ea

Loading...

devel/gdb/files/commit-983b1119bc3

Loading...

devel/gdb/files/commit-a171378aa47

Loading...

devel/gdb/files/commit-a3627b54280

Loading...

devel/gdb/files/commit-a49ce729c80

Loading...

devel/gdb/files/commit-a980a7d24b9

Loading...

devel/gdb/files/commit-b1babce7c31

Loading...

devel/gdb/files/commit-b2fdd31b03e

Loading...

devel/gdb/files/commit-b5c2367c3ac

Loading...

devel/gdb/files/commit-b7fe5463cf0

Loading...

devel/gdb/files/commit-c13566fdd57

Loading...

devel/gdb/files/commit-c77282d8ba9

Loading...

devel/gdb/files/commit-e330d4c033e

Loading...

devel/gdb/files/commit-f3215e1526d

Loading...

devel/gdb/files/commit-f9fbb7636a5

Loading...

devel/gdb/files/extrapatch-kgdb

Loading...

devel/gdb/files/kgdb/aarch64-fbsd-kern.c

Loading...

devel/gdb/files/kgdb/amd64fbsd-kern.c

Loading...

devel/gdb/files/kgdb/arm-fbsd-kern.c

Loading...

devel/gdb/files/kgdb/fbsd-kld.c

Loading...

devel/gdb/files/kgdb/fbsd-kthr.c

Loading...

devel/gdb/files/kgdb/fbsd-kvm.c

Loading...

devel/gdb/files/kgdb/i386fbsd-kern.c

Loading...

devel/gdb/files/kgdb/mipsfbsd-kern.c

Loading...

devel/gdb/files/kgdb/ppcfbsd-kern.c

Loading...

devel/gdb/files/kgdb/riscv-fbsd-kern.c

Loading...

devel/gdb/files/kgdb/sparc64fbsd-kern.c

Loading...

devel/gdb/files/patch-gdb-completer.c

Loading...

devel/gdb/files/patch-gnulib_import_stddef.in.h

Loading...

devel/gdb/pkg-plist

Loading...