Page MenuHomeFreeBSD

biology/ncbi-entrez-direct: fix build on riscv64
ClosedPublic

Authored by fuz on Mar 9 2023, 1:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 23, 2:31 AM
Unknown Object (File)
Tue, Jul 21, 3:02 AM
Unknown Object (File)
Mon, Jul 20, 8:41 AM
Unknown Object (File)
Sun, Jul 19, 8:10 PM
Unknown Object (File)
Sat, Jul 18, 8:16 AM
Unknown Object (File)
Sat, Jul 18, 7:07 AM
Unknown Object (File)
Wed, Jul 1, 7:29 PM
Unknown Object (File)
Wed, Jul 1, 7:28 PM
Subscribers

Details

Summary
biology/ncbi-entrez-direct: fix build on riscv64

Bump golang.org/x/sys dependency to a version new
enough to build on riscv64-freebsd.

Sponsored by:	Berliner Linux User Group e.V.
Approved by:	portmgr (build fix blanket)

Posted for maintainer feedback.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 50244
Build 47136: arc lint + arc unit

Event Timeline

fuz requested review of this revision.Mar 9 2023, 1:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2023, 8:39 AM
This revision was automatically updated to reflect the committed changes.

Did someone do run testing on these updates before committing?

Seems a bit of a stretch to use the build fix blanket to change dependency versions for a port was not broken on amd64, in order to add support for a platform on which nobody is likely to be doing bioinformatics work.

I just did some basic testing and it appears that no harm was done in this case, but I think we should not risk regressions out of impatience. I did indicate that I was aware of the review and was testing it myself.

Hi @jwb, I did a Poudriere build test on i386, amd64, armv7, armv64, and riscv64 FreeBSD 13.1 (and some also 12.4). The tests completed successfully. The golang.org/x/sys package wraps system calls. Updating it is very unlikely to change anything about the code. Thank you for performing additional tests.