biology/ncbi-entrez-direct: fix build on riscv64
ClosedPublic
Actions

Authored by fuz on Mar 9 2023, 1:20 AM.

Details

Reviewers

jwb

Commits

R11:8ede8da5f192: biology/ncbi-entrez-direct: fix build on riscv64

Summary

biology/ncbi-entrez-direct: fix build on riscv64

Bump golang.org/x/sys dependency to a version new
enough to build on riscv64-freebsd.

Sponsored by:	Berliner Linux User Group e.V.
Approved by:	portmgr (build fix blanket)

Posted for maintainer feedback.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 50244
Build 47136: arc lint + arc unit

Event Timeline

fuz created this revision.Mar 9 2023, 1:20 AM

Herald added a subscriber: mat. · View Herald TranscriptMar 9 2023, 1:20 AM

fuz requested review of this revision.Mar 9 2023, 1:20 AM

Harbormaster completed remote builds in B50244: Diff 118562.Mar 9 2023, 1:20 AM

Testing...

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2023, 8:39 AM

Closed by commit R11:8ede8da5f192: biology/ncbi-entrez-direct: fix build on riscv64 (authored by fuz). · Explain Why

This revision was automatically updated to reflect the committed changes.

fuz added a commit: R11:8ede8da5f192: biology/ncbi-entrez-direct: fix build on riscv64.

Did someone do run testing on these updates before committing?

Seems a bit of a stretch to use the build fix blanket to change dependency versions for a port was not broken on amd64, in order to add support for a platform on which nobody is likely to be doing bioinformatics work.

I just did some basic testing and it appears that no harm was done in this case, but I think we should not risk regressions out of impatience. I did indicate that I was aware of the review and was testing it myself.

Hi @jwb, I did a Poudriere build test on i386, amd64, armv7, armv64, and riscv64 FreeBSD 13.1 (and some also 12.4). The tests completed successfully. The golang.org/x/sys package wraps system calls. Updating it is very unlikely to change anything about the code. Thank you for performing additional tests.