Page MenuHomeFreeBSD
Differential D38961

src.conf.5: Add some WITH_/WITHOUT_ option descriptions
ClosedPublic
Actions

Authored by emaste on Mar 7 2023, 8:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 29, 1:07 PM
Unknown Object (File)
Wed, Oct 29, 12:54 PM
Unknown Object (File)
Wed, Oct 29, 12:51 PM
Unknown Object (File)
Wed, Oct 29, 12:50 PM
Unknown Object (File)
Mon, Oct 27, 2:35 PM
Unknown Object (File)
Sat, Oct 25, 11:34 AM
Unknown Object (File)
Fri, Oct 24, 8:35 AM
Unknown Object (File)
Thu, Oct 23, 6:38 PM
View All Files
Subscribers
None

Details

Reviewers
imp
markj
brooks
Commits
rGc581962414ed: src.conf.5: Add some WITH_/WITHOUT_ option descriptions

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Mar 7 2023, 8:57 PM
emaste created this revision.
emaste added reviewers: imp, markj.
emaste updated this revision to Diff 118497.Mar 7 2023, 9:10 PM

expand sctp

markj added inline comments.Mar 7 2023, 9:47 PM
tools/build/options/WITHOUT_SCTP_SUPPORT
4

Isn't this a kernel config option, not a src.conf option?

emaste added a comment.Mar 7 2023, 11:27 PM

It's (also) parsed as a src.conf option, from 90297b64718e7

I'm not really sure what the right answer here is.

markj accepted this revision.Mar 8 2023, 2:51 PM
markj added inline comments.
tools/build/options/WITHOUT_SCTP_SUPPORT
1
4

Ah I see. I think it's fine to document then.

tools/build/options/WITH_OFED
3
This revision is now accepted and ready to land.Mar 8 2023, 2:51 PM
brooks added a child revision: D38991: Cirrus-CI: Add a task to check housekeeping state.Mar 8 2023, 6:54 PM
brooks mentioned this in D38991: Cirrus-CI: Add a task to check housekeeping state.Mar 8 2023, 6:56 PM
brooks accepted this revision.Mar 8 2023, 10:12 PM
Closed by commit rGc581962414ed: src.conf.5: Add some WITH_/WITHOUT_ option descriptions (authored by emaste). · Explain WhyMar 8 2023, 11:31 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGc581962414ed: src.conf.5: Add some WITH_/WITHOUT_ option descriptions.

Revision Contents
Changeset List

PathSize
tools/
build/
options/
4 lines
3 lines
3 lines
3 lines

Diff 118497

View Options

tools/build/options/WITHOUT_SCTP_SUPPORT

Loading...
View Options

tools/build/options/WITH_LIB32

Loading...
View Options

tools/build/options/WITH_OFED

Loading...
View Options

tools/build/options/WITH_ZFS

Loading...