Page MenuHomeFreeBSD
Differential D38931

byacc: Disable backtracking extension.
ClosedPublic
Actions

Authored by des on Mar 6 2023, 6:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 15, 6:50 PM
Unknown Object (File)
Wed, Apr 15, 3:39 PM
Unknown Object (File)
Wed, Apr 15, 3:38 PM
Unknown Object (File)
Thu, Apr 9, 6:47 PM
Unknown Object (File)
Wed, Apr 8, 9:51 PM
Unknown Object (File)
Mon, Apr 6, 2:09 PM
Unknown Object (File)
Sun, Apr 5, 6:03 PM
Unknown Object (File)
Sat, Apr 4, 11:11 AM
View All 93 Files
Subscribers
imp

Details

Reviewers
jkim
imp
Group Reviewers
Klara
Commits
rG473a2c9a40e8: byacc: Disable backtracking extension.
Summary

When updating byacc to 20230201, I enabled the backtracking extension as it seemed useful and harmless. With a little more experience, it appears to have more impact than I initially thought and I'm no longer sure how useful it really is, so turn it back off.

PR: 244149, 269425
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50171
Build 47063: arc lint + arc unit

Event Timeline

des created this revision.Mar 6 2023, 6:11 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 6 2023, 6:11 PM
des requested review of this revision.Mar 6 2023, 6:11 PM
Harbormaster completed remote builds in B50171: Diff 118408.Mar 6 2023, 6:11 PM
des edited the summary of this revision. (Show Details)Mar 6 2023, 6:13 PM
jkim accepted this revision.Mar 6 2023, 7:06 PM

LGTM

This revision is now accepted and ready to land.Mar 6 2023, 7:06 PM
imp accepted this revision.Mar 6 2023, 8:43 PM

I believe that dtc uses (or used) it?
But not in base, and the port already does the right workarounds.

Closed by commit rG473a2c9a40e8: byacc: Disable backtracking extension. (authored by des). · Explain WhyMar 7 2023, 5:22 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG473a2c9a40e8: byacc: Disable backtracking extension..

Revision Contents
Changeset List

PathSize
usr.bin/
yacc/
2 lines

Diff 118408

View Options

usr.bin/yacc/config.h

Loading...