games/kanatest: fix ports compliance - change += into = where appropriate While the Porter's Handbook wants us to place japanese as the first category, Poudriere wants games to be the first category. Given that an unhappy Poudriere leads to a broken port, this was not changed. Reported by: eduardo Approved by: infrastructure change blanket Approved by: ... (mentor)
Details
Details
- Reviewers
eduardo flo - Commits
- R11:f94341404968: games/kanatest: fix ports compliance
Tested with Poudriere on i386 amd64 FreeBSD 12.4 13.1. Arm64 tests pending.
See test results at: http://fuz.su/~fuz/freebsd/batch2
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 49844 Build 46735: arc lint + arc unit
Event Timeline
Comment Actions
Try to follow documentation and refer blanket commits more similarly such as portmgr (blanket) instead of "infrastructure change blanket", you can also just use a single line. Approved by: portmgr (blanket), XXX (mentor) in commit message
https://docs.freebsd.org/en/articles/committers-guide/#ports-qa-misc-blanket-approval
Comment Actions
Thanks, I will do that when committing. I was unaware of the specific convention required.
Comment Actions
CATEGORIES= games japanese seems to be correct.
Kanatest port is located at games and listed on japanese second category.
There is other cases where both ports exists, e.g., editors/jed and japanese/jed and CATEGORIES are set accordingly for both ports.