hyperv: Fix Coverity issues in the Hyper-V driver
ClosedPublic
Actions

Authored by dab on Feb 12 2023, 11:21 PM.

Details

Reviewers

robert.herndon_dell.com
vangyzen
bret_ketchum_dell.com
michael.baptist_dell.com

Commits

rGb086426bc210: hyperv: Fix Coverity issues in the Hyper-V driver

Summary

Coverity reports the use of two uninitialized variables in the hyperv
driver. Examination shows the variables can be accessed while
uninitialized in error cases. Fix both.

CID: 1365235
CID: 1365236
Obtained from: Robert Herndon <Robert.Herndon@Dell.com>
Sponsored by: Dell Technologies
MFC after: 1w

Test Plan

Changes in use at $WORK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 49783
Build 46673: arc lint + arc unit

Event Timeline

dab created this revision.Feb 12 2023, 11:21 PM

Herald added subscribers: badger, imp. · View Herald TranscriptFeb 12 2023, 11:21 PM

dab requested review of this revision.Feb 12 2023, 11:21 PM

Harbormaster completed remote builds in B49722: Diff 117064.Feb 12 2023, 11:21 PM

Re-submit

Harbormaster completed remote builds in B49723: Diff 117065.Feb 12 2023, 11:27 PM

dab added a reviewer: michael.baptist_dell.com.Feb 14 2023, 2:48 PM

LGTM

Common practice for attributing the submitter with git is:

git commit --amend --author='Robert Herndon <Robert.Herndon@Dell.com>'

This revision is now accepted and ready to land.Feb 14 2023, 2:55 PM

bret_ketchum_dell.com accepted this revision.Feb 14 2023, 2:57 PM

michael.baptist_dell.com accepted this revision.Feb 14 2023, 3:07 PM

In D38551#877968, @vangyzen wrote:

Common practice for attributing the submitter with git is:

git commit --amend --author='Robert Herndon <Robert.Herndon@Dell.com>'

Ah, good to know. I actually used git am to apply the patch and it annotated the commit that way. I "fixed" it to list me. I'll change it back and remember this for the future.

Does that then take the place of "Obtained from" and/or "Submitted by"?

Re-trying to approve this change. (Please ignore if redundant.)

Correct author in commit log.

This revision now requires review to proceed.Feb 14 2023, 4:51 PM

Harbormaster completed remote builds in B49783: Diff 117217.Feb 14 2023, 4:51 PM

bret_ketchum_dell.com accepted this revision.Feb 14 2023, 4:55 PM

This revision is now accepted and ready to land.Feb 14 2023, 4:55 PM

Closed by commit rGb086426bc210: hyperv: Fix Coverity issues in the Hyper-V driver (authored by robert.herndon_dell.com, committed by dab). · Explain WhyFeb 16 2023, 2:24 AM

This revision was automatically updated to reflect the committed changes.

dab added a commit: rGb086426bc210: hyperv: Fix Coverity issues in the Hyper-V driver.