Reported by: mav
MFC after: 1 week
Sponsored by: Axcient
Details
Details
Ran all subcommands with valgrind
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 49658 Build 46548: arc lint + arc unit
Event Timeline
Comment Actions
I have no objections, just some comments to polish.
| usr.sbin/sesutil/sesutil.c | ||
|---|---|---|
| 496 | You've left this assignment here, but removed elm_names_size assignment below. Moving this up would look cleaner. I was thinking about some constant, but if variable assignment would be moved up and passed as a variable to malloc(), it would be less needed. | |
| usr.sbin/sesutil/sesutil.c | ||
|---|---|---|
| 496 | Actually, elm_desc_len is a R/W argument to ENCIOC_GETELMDESC. On entry, it indicates the space available in elm_devnames. On return, it indicates the size of the string, which is not nul-terminated. That's why I have to set it here instead of next to the calloc. | |