Page MenuHomeFreeBSD

sesutil: don't malloc in a tight loop
ClosedPublic

Authored by asomers on Feb 9 2023, 10:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 6:00 PM
Unknown Object (File)
Fri, Nov 22, 6:41 AM
Unknown Object (File)
Fri, Nov 22, 5:51 AM
Unknown Object (File)
Fri, Nov 22, 5:13 AM
Unknown Object (File)
Wed, Nov 20, 12:14 AM
Unknown Object (File)
Mon, Nov 18, 11:24 AM
Unknown Object (File)
Mon, Nov 18, 10:19 AM
Unknown Object (File)
Mon, Nov 18, 9:55 AM
Subscribers

Details

Summary

Reported by: mav
MFC after: 1 week
Sponsored by: Axcient

Test Plan

Ran all subcommands with valgrind

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 49658
Build 46548: arc lint + arc unit

Event Timeline

I have no objections, just some comments to polish.

usr.sbin/sesutil/sesutil.c
496

You've left this assignment here, but removed elm_names_size assignment below. Moving this up would look cleaner. I was thinking about some constant, but if variable assignment would be moved up and passed as a variable to malloc(), it would be less needed.

This revision is now accepted and ready to land.Feb 13 2023, 2:48 PM
usr.sbin/sesutil/sesutil.c
496

Actually, elm_desc_len is a R/W argument to ENCIOC_GETELMDESC. On entry, it indicates the space available in elm_devnames. On return, it indicates the size of the string, which is not nul-terminated. That's why I have to set it here instead of next to the calloc.

This revision was automatically updated to reflect the committed changes.