tzcode: garbage collect references to tzsetwall
AbandonedPublic
Actions

Authored by val_packett.cool on Feb 6 2023, 8:13 PM.

Details

Reviewers

des
emaste

Group Reviewers

Contributor Reviews (src)

Summary

It was removed with the recent update to upstream tzcode, but references in the header, symbol map and man pages remained.

Fixes: bc42155199 ("Bring our tzcode up to date.")
Reported by: ld.lld 16 being --no-undefined-version by default
Sponsored by: https://www.patreon.com/valpackett

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49575
Build 46465: arc lint + arc unit

Event Timeline

val_packett.cool created this revision.Feb 6 2023, 8:13 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 6 2023, 8:13 PM

val_packett.cool requested review of this revision.Feb 6 2023, 8:13 PM

Harbormaster completed remote builds in B49575: Diff 116641.Feb 6 2023, 8:13 PM

val_packett.cool edited the summary of this revision. (Show Details)Feb 6 2023, 8:14 PM

val_packett.cool added reviewers: Contributor Reviews (src), des, emaste.

I honestly hadn't noticed that the tzcode update removed tzsetwall(3).

On the one hand, it's useless and nobody should be calling it.

On the other hand, we've had it for 30+ years and it's arguably part of our ABI.

On the gripping hand, this was merged to stable/13 eight days ago and nobody (including the package builders) noticed.

What do you think @emaste @imp? Should we reintroduce it as an alias for tzset(3), or implement something ourselves? I think the closest thing to the original spirit is “like tzset(3) but ignores the TZ environment variable, taking only /etc/localtime into account.”