Note that I intended to add assertions to be64enc_vect() and be64dec_vect(), but since the same code is used both in the kernel and in user space, it would have been needlessly complicated.

You're going to be adding test cases for this in libmd, right?

This revision is now accepted and ready to land.Feb 4 2023, 2:43 PM

In D38372#872487, @cperciva wrote:

You're going to be adding test cases for this in libmd, right?

Yes, see D38373. That's how I found the bug.

Closed by commit rG6680cfe8e0ee: sha512_224: Fix SHA512_224_Final() on little-endian machines. (authored by sebastian.huber_embedded-brains.de, committed by des). · Explain WhyFeb 6 2023, 5:04 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG6680cfe8e0ee: sha512_224: Fix SHA512_224_Final() on little-endian machines..

des added a commit: rGb9e0160e0788: sha512_224: Fix SHA512_224_Final() on little-endian machines..Feb 9 2023, 8:41 PM

des added a commit: rG316cf82382e0: sha512_224: Fix SHA512_224_Final() on little-endian machines..Feb 10 2023, 12:24 AM

Revision Contents
Changeset List

Path

Size

sys/

crypto/

sha2/

sha512c.c

13 lines

Diff 116394

View Options

sha512_224: Fix SHA512_224_Final() on little-endian machines.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 116394

sys/crypto/sha2/sha512c.c

sha512_224: Fix SHA512_224_Final() on little-endian machines.
ClosedPublic
Actions

Revision Contents
Changeset List