Page MenuHomeFreeBSD

sha512_224: Fix SHA512_224_Final() on little-endian machines.
ClosedPublic

Authored by des on Feb 3 2023, 3:21 PM.
Tags
None
Referenced Files
F132476814: D38372.id116394.diff
Fri, Oct 17, 6:14 AM
F132423202: D38372.id.diff
Thu, Oct 16, 7:41 PM
F132416050: D38372.id116580.diff
Thu, Oct 16, 6:12 PM
Unknown Object (File)
Wed, Oct 15, 9:25 PM
Unknown Object (File)
Fri, Oct 10, 12:48 AM
Unknown Object (File)
Fri, Oct 10, 12:48 AM
Unknown Object (File)
Thu, Oct 9, 9:29 PM
Unknown Object (File)
Thu, Oct 9, 9:21 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Feb 3 2023, 3:21 PM

Note that I intended to add assertions to be64enc_vect() and be64dec_vect(), but since the same code is used both in the kernel and in user space, it would have been needlessly complicated.

You're going to be adding test cases for this in libmd, right?

This revision is now accepted and ready to land.Feb 4 2023, 2:43 PM

You're going to be adding test cases for this in libmd, right?

Yes, see D38373. That's how I found the bug.