Page MenuHomeFreeBSD
Differential D38372

sha512_224: Fix SHA512_224_Final() on little-endian machines.
ClosedPublic
Actions

Authored by des on Feb 3 2023, 3:21 PM.
Tags
None
Referenced Files
F132476814: D38372.id116394.diff
Fri, Oct 17, 6:14 AM
F132423202: D38372.id.diff
Thu, Oct 16, 7:41 PM
F132416050: D38372.id116580.diff
Thu, Oct 16, 6:12 PM
Unknown Object (File)
Wed, Oct 15, 9:25 PM
Unknown Object (File)
Fri, Oct 10, 12:48 AM
Unknown Object (File)
Fri, Oct 10, 12:48 AM
Unknown Object (File)
Thu, Oct 9, 9:29 PM
Unknown Object (File)
Thu, Oct 9, 9:21 PM
View All Files
Subscribers
imp

Details

Reviewers
cperciva
Group Reviewers
Klara
Commits
rG316cf82382e0: sha512_224: Fix SHA512_224_Final() on little-endian machines.
rGb9e0160e0788: sha512_224: Fix SHA512_224_Final() on little-endian machines.
rG6680cfe8e0ee: sha512_224: Fix SHA512_224_Final() on little-endian machines.
Summary

PR: 266863
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Feb 3 2023, 3:21 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2023, 3:21 PM
des requested review of this revision.Feb 3 2023, 3:21 PM
Harbormaster completed remote builds in B49509: Diff 116394.Feb 3 2023, 3:21 PM
des added a child revision: D38373: libmd / md5: Add SHA-512/224..Feb 3 2023, 3:21 PM
des added reviewers: Klara, cperciva.Feb 3 2023, 3:24 PM
des added a comment.Feb 3 2023, 3:27 PM

Note that I intended to add assertions to be64enc_vect() and be64dec_vect(), but since the same code is used both in the kernel and in user space, it would have been needlessly complicated.

cperciva accepted this revision.Feb 4 2023, 2:43 PM

You're going to be adding test cases for this in libmd, right?

This revision is now accepted and ready to land.Feb 4 2023, 2:43 PM
des added a comment.Feb 6 2023, 12:11 PM
In D38372#872487, @cperciva wrote:

You're going to be adding test cases for this in libmd, right?

Yes, see D38373. That's how I found the bug.

Closed by commit rG6680cfe8e0ee: sha512_224: Fix SHA512_224_Final() on little-endian machines. (authored by sebastian.huber_embedded-brains.de, committed by des). · Explain WhyFeb 6 2023, 5:04 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG6680cfe8e0ee: sha512_224: Fix SHA512_224_Final() on little-endian machines..
des added a commit: rGb9e0160e0788: sha512_224: Fix SHA512_224_Final() on little-endian machines..Feb 9 2023, 8:41 PM
des added a commit: rG316cf82382e0: sha512_224: Fix SHA512_224_Final() on little-endian machines..Feb 10 2023, 12:24 AM

Revision Contents
Changeset List

PathSize
sys/
crypto/
sha2/
13 lines

Diff 116580

View Options

sys/crypto/sha2/sha512c.c

Loading...