Page MenuHomeFreeBSD
Differential D4689

bsdinstall(8) umount target should be able to unmount zfs filesystems
AbandonedPublic
Actions

Authored by kczekirda on Dec 22 2015, 9:58 PM.
Tags
None
Referenced Files
F175208010: D4689.id11769.diff
Fri, Oct 9, 2:50 AM
Unknown Object (File)
Thu, Oct 8, 7:14 PM
Unknown Object (File)
Thu, Oct 8, 5:31 AM
Unknown Object (File)
Wed, Oct 7, 2:28 PM
Unknown Object (File)
Wed, Oct 7, 11:18 AM
Unknown Object (File)
Mon, Oct 5, 10:45 PM
Unknown Object (File)
Mon, Oct 5, 10:45 PM
Unknown Object (File)
Mon, Oct 5, 10:45 PM
View All Files
Subscribers
None

Details

Reviewers
dteske
nwhitehorn
allanjude
Summary

It's not a perfect, but it's enough for 99% use cases.

From Bugzilla:

fre.fbsdpr@expertmaker.com 2015-11-12 15:41:13 UTC
Hi,

When calling the script target with the ZFSBOOT_DISKS variable set, the zfsboot target will be run. This logic should also be used for the umount target, choosing 'zfs umount -a' to be run.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kczekirda updated this revision to Diff 11620.Dec 22 2015, 9:58 PM
kczekirda retitled this revision from to bsdinstall(8) umount target should be able to unmount zfs filesystems.
kczekirda updated this object.
kczekirda edited the test plan for this revision. (Show Details)
kczekirda added reviewers: allanjude, dteske.
kczekirda added a reviewer: nwhitehorn.Dec 22 2015, 10:32 PM
nwhitehorn edited edge metadata.Dec 23 2015, 1:30 AM

The use case when installing multiuser is not that uncommon and is something that needs to continue working. One of two things needs to happen here before being committed:
(a) it needs to use only those ZFS filesystems previously mounted
(b) the zfsboot script should use the ZFS support in partedit, which already works with umount

allanjude added inline comments.Dec 23 2015, 2:43 AM
usr.sbin/bsdinstall/scripts/umount
43

in multiuser mode, this command will fail, because you can't umount / while your CWD is / or a subdirectory of it.

When bsdinstall sees an error, it will prompt the user to start the entire install over again.

Wouldn't 'zfs unmount $BSDINSTALL_CHROOT' work here? ($BSDINSTALL_CHROOT = /mnt)

It would unmount only the file systems mounted under the chroot and their descendants.

kczekirda added a comment.Dec 23 2015, 8:59 AM
In D4689#98951, @nwhitehorn wrote:

The use case when installing multiuser is not that uncommon and is something that needs to continue working. One of two things needs to happen here before being committed:
(a) it needs to use only those ZFS filesystems previously mounted
(b) the zfsboot script should use the ZFS support in partedit, which already works with umount

I can do (a), but I'm not able to work on (b).

kczekirda updated this revision to Diff 11769.Dec 29 2015, 10:16 PM
kczekirda edited edge metadata.
kczekirda marked an inline comment as done.
kczekirda updated this revision to Diff 11770.Dec 29 2015, 10:21 PM
allanjude added inline comments.Apr 8 2016, 3:51 PM
scripts/umount
49 ↗(On Diff #11770)

If this were to return an error, wouldn't it cause bsdinstall to prompt the user to start the installation over again?

Also, if there is somehow a mountpoint that will not unmount because it is in use (say, the shell on console #4 was in that directory), this will loop forever.

kczekirda abandoned this revision.Mar 21 2019, 9:49 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
scripts/
1 line

Diff 11620

View Options

usr.sbin/bsdinstall/scripts/umount

Loading...