Details
- Reviewers
jhb - Commits
- rG87e728340b1d: Mechanically convert wg(4) to IfAPI
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 49377 Build 46267: arc lint + arc unit
Event Timeline
Just one minor nit that would be nice to fix during commit.
sys/dev/wg/if_wg.c | ||
---|---|---|
1680 | Would be nice to preserve existing indentation here. |
sys/dev/wg/if_wg.c | ||
---|---|---|
1680 | Ack, will do. The script unfortunately doesn't preserve whitespace. I thought I fixed all instances of it, but missed this one. |
Any specific reason to write the or statement as two separate if clauses?
I believe in other parts we do it ((true & x & y & z) | (false & a & b &c )) - as multiline checks;
I don't like them both get executed "always", so at the very least, an "else" just before the 2nd if would be good.
The logic looks ok to me.