Page MenuHomeFreeBSD
Differential D4679

RISC-V runtime-linker (rtld-elf) MD part
ClosedPublic
Actions

Authored by br on Dec 22 2015, 11:54 AM.
Tags
None
Referenced Files
F133069781: D4679.id11576.diff
Wed, Oct 22, 4:53 PM
Unknown Object (File)
Sun, Oct 19, 7:05 PM
Unknown Object (File)
Fri, Oct 17, 11:11 PM
Unknown Object (File)
Wed, Oct 15, 12:45 AM
Unknown Object (File)
Tue, Oct 14, 5:37 PM
Unknown Object (File)
Sun, Oct 12, 7:56 AM
Unknown Object (File)
Sun, Oct 12, 6:06 AM
Unknown Object (File)
Sat, Oct 4, 10:13 AM
View All Files
Subscribers
None

Details

Reviewers
kib
emaste
andrew
Commits
rS292691: Add support for RISC-V architecture.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br updated this revision to Diff 11576.Dec 22 2015, 11:54 AM
br retitled this revision from to RISC-V runtime-linker (rtld-elf) MD part.
br updated this object.
br edited the test plan for this revision. (Show Details)
br added reviewers: andrew, emaste.
andrew added a reviewer: kib.Dec 22 2015, 3:18 PM
andrew added inline comments.
libexec/rtld-elf/riscv/rtld_machdep.h
50–55

Can you implement this as #define rtld_dynamic(obj) (&_DYNAMIC)? It's special on arm64 because otherwise the _DYNAMIC symbol needs to be relocated.

libexec/rtld-elf/riscv/rtld_start.S
68

Why 72?

77

Why are you saving this?

80–89

These are wrong, the offset will trample over the a registers above.

br updated this revision to Diff 11598.Dec 22 2015, 4:45 PM

floating point operations fixed

br added inline comments.Dec 22 2015, 4:50 PM
libexec/rtld-elf/riscv/rtld_machdep.h
50–55

We also need this on RISC-V, I don't remember the reason, but it doesn't work with suggested define

libexec/rtld-elf/riscv/rtld_start.S
68

9 regs to save

77

We need that probably because jal overwrites it. So it does not work if we remove that.

80–89

thanks!

br added inline comments.Dec 22 2015, 4:51 PM
libexec/rtld-elf/riscv/rtld_start.S
77

BTW, I just looked to Linux port, they do also saving ra.

andrew added inline comments.Dec 22 2015, 5:26 PM
libexec/rtld-elf/riscv/rtld_machdep.h
50–55

I suspect for similar reasons (I was just making sure it wasn't just because that's how arm64 does it).

libexec/rtld-elf/riscv/rtld_start.S
68

I normally write it as addi sp, sp, -(8 * 9) to make it obvious we are saving space for 9 8-byte registers.

81

Why not move this to the above addi? It should just cost the stack space if it's not used.

br updated this revision to Diff 11631.Dec 23 2015, 11:38 AM
kib edited edge metadata.Dec 23 2015, 6:05 PM

I have no idea about RISC-V arch, so I did not catched anything unusual in the arch support.

libexec/rtld-elf/riscv/reloc.c
64

We usually spell this as

__asm __volatile
84

Space between ) and next part of the expression is not needed.

br updated this revision to Diff 11640.Dec 23 2015, 6:19 PM
br edited edge metadata.

fix style

andrew accepted this revision.Dec 23 2015, 7:39 PM
andrew edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2015, 7:39 PM
Closed by commit rS292691: Add support for RISC-V architecture. (authored by br). · Explain WhyDec 24 2015, 3:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
libexec/
rtld-elf/
riscv/
400 lines
111 lines
133 lines
2 lines

Diff 11598

View Options

libexec/rtld-elf/riscv/reloc.c

Loading...
View Options

libexec/rtld-elf/riscv/rtld_machdep.h

Loading...
View Options

libexec/rtld-elf/riscv/rtld_start.S

Loading...
View Options

libexec/rtld-elf/rtld.c

Loading...