w: Complete libxo transition.
ClosedPublic
Actions

Authored by des on Jan 23 2023, 4:24 PM.

Details

Reviewers

markj

Group Reviewers

Klara

Commits

rGa6edc5b39209: w: Complete libxo transition.
rGd90ff31ae5cd: w: Complete libxo transition.

Summary

MFC after: 1 week
Sponsred by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49204
Build 46093: arc lint + arc unit

Event Timeline

des created this revision.Jan 23 2023, 4:24 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 23 2023, 4:24 PM

des requested review of this revision.Jan 23 2023, 4:24 PM

Harbormaster completed remote builds in B49197: Diff 115452.Jan 23 2023, 4:24 PM

markj added a subscriber: markj.Jan 23 2023, 7:36 PM

markj added inline comments.

usr.bin/w/w.c
475–476	It looks like xo_finish() returns a number of bytes written, so shouldn't we be checking for a result `< 0`?

Fix xo_finish() check

Harbormaster completed remote builds in B49204: Diff 115510.Jan 24 2023, 8:49 AM

des marked an inline comment as done.Jan 24 2023, 8:49 AM

des added inline comments.

usr.bin/w/w.c
475–476	You are absolutely right.

markj accepted this revision as: markj.Jan 24 2023, 2:06 PM

This revision is now accepted and ready to land.Jan 24 2023, 2:06 PM

Closed by commit rGd90ff31ae5cd: w: Complete libxo transition. (authored by des). · Explain WhyJan 25 2023, 6:23 AM

This revision was automatically updated to reflect the committed changes.

des marked an inline comment as done.

des added a commit: rGd90ff31ae5cd: w: Complete libxo transition..

des added a commit: rGa6edc5b39209: w: Complete libxo transition..Feb 9 2023, 8:41 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

w.c

17 lines

Diff 115510

View Options

w: Complete libxo transition.ClosedPublicActions