Paths

Table of Contentst

Differential D38087

lindebugfs: Add missing `debugfs_create_u()` and `debugfs_create_x()`
ClosedPublic
Actions

Authored by dumbbell on Jan 16 2023, 7:48 PM.

Tags

None

Referenced Files

	F132924363: D38087.id.diff
	Tue, Oct 21, 5:41 AM

	Unknown Object (File)
	Sat, Oct 18, 5:06 PM

	Unknown Object (File)
	Sat, Oct 18, 5:06 PM

	Unknown Object (File)
	Sat, Oct 18, 5:06 PM

	Unknown Object (File)
	Sat, Oct 18, 5:06 PM

	Unknown Object (File)
	Sat, Oct 18, 6:17 AM

	Unknown Object (File)
	Sun, Oct 12, 7:26 AM

	Unknown Object (File)
	Sat, Oct 4, 9:10 AM

View All 87 Files

Subscribers

Details

Reviewers

Commits

rG76bad151d180: lindebugfs: Add missing `debugfs_create_u*()` and `debugfs_create_x*()`
rG976aa07a885b: lindebugfs: Add missing `debugfs_create_u*()` and `debugfs_create_x*()`

Summary

The debugfs_create_x*() variants are the same as their debugfs_create_u*() equivalent, but they work with lowercase hexadecimal.

This is part of the update of the DRM drivers to Linux 5.13.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Jan 16 2023, 7:48 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptJan 16 2023, 7:48 PM

dumbbell requested review of this revision.Jan 16 2023, 7:48 PM

dumbbell updated this revision to Diff 115400.Jan 22 2023, 1:59 PM

dumbbell retitled this revision from lindebugfs: Add `debugfs_create_u16()` and `debugfs_create_u32()` to lindebugfs: Add missing `debugfs_create_u*()` and `debugfs_create_x*()`.

dumbbell edited the summary of this revision. (Show Details)

Some style(9) nits but otherwise looks good.

sys/compat/lindebugfs/lindebugfs.c
414	style(9) need new line.
423	style(9) need new line.
431	style(9) need new line.
442	style(9) need new line.
453	style(9) need new line.
462	style(9) need new line.
470	style(9) need new line.
481	style(9) need new line.
492	style(9) need new line.
501	style(9) need new line.
509	style(9) need new line.
520	style(9) need new line.
531	style(9) need new line.

This revision is now accepted and ready to land.Jan 23 2023, 7:41 AM

I fixed the style(9) in the final commit.

Closed by commit rG976aa07a885b: lindebugfs: Add missing `debugfs_create_u*()` and `debugfs_create_x*()` (authored by dumbbell). · Explain WhyJan 25 2023, 9:39 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rG976aa07a885b: lindebugfs: Add missing `debugfs_create_u*()` and `debugfs_create_x*()`.

dumbbell added a commit: rG76bad151d180: lindebugfs: Add missing `debugfs_create_u*()` and `debugfs_create_x*()`.Feb 16 2023, 11:56 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

lindebugfs/

128 lines

linuxkpi/

common/

include/

linux/

14 lines

Diff 115400

sys/compat/lindebugfs/lindebugfs.c

Loading...

sys/compat/linuxkpi/common/include/linux/debugfs.h

Loading...