poudriere OK on arm64 & amd64 13.1-RELEASE + CURRENT
- needs a decent pkg-message explaining usage
- and some real-world functional testing
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 49111 Build 46000: arc lint + arc unit
Event Timeline
Comment Actions
some questions and recommendations
| www/hedgedoc/Makefile | ||
|---|---|---|
| 13 | ||
| 59 | what does this do? | |
| 103 | can you briefly explain what all the things are that we're grooving here? | |
| www/hedgedoc/files/hedgedoc.in | ||
| 27 | I don't know if this is the best idea i think a dedicated user would be better | |
| 44 | indentation seems off here | |
| www/hedgedoc/Makefile | ||
|---|---|---|
| 13 | what do you mean here? I've tested the sqlite variant, should we add other ones as well? | |
| 59 | this is my ports tree helper, to build the yarn cache tarball, that is eventually stored in LOCAL/dch distfiles. | |
| 103 | these are all the tmp garbage files created during build of each module, that we don't need to ship. | |
| www/hedgedoc/files/hedgedoc.in | ||
| 27 | I will add *IDs | |
| 27 | btw there's nothing stopping people adding their own users with this setup. but we have 500+ IDs free, so lets use one. | |
| www/hedgedoc/Makefile | ||
|---|---|---|
| 13 | SQLite is necessary for the b build. the instructions above do tell you what you need to do, but not how we could add those instructions ourselves | |
| 103 | it feels like this should be more generalisable, given that we end up with 16 Thousand files in plist, but it's probably a good enough start | |
| www/hedgedoc/pkg-plist | ||
|---|---|---|
| 6 | are you modifying any config or anything to tell hedgedoc where to find its documentation?? | |