Differential D37889

net-mgmt/netdata: Update to 1.37.1
ClosedPublic
Actions

Authored by woodsb02 on Dec 28 2022, 1:40 AM.

Details

Reviewers

Commits

R11:14e7c1f66098: net-mgmt/netdata: Update to 1.37.1

Summary

Includes fixes for recent streaming security vulnerabilities
Also remove custom dashboard as a patch for 1.37 wasn't available https://github.com/forkbomb9/netdata

Security: 4b60c3d9-8640-11ed-a762-482ae324f959

Test Plan

poudriere testport - no errors with CLOUD options on or off
Run testing shows the local and cloud dashboards are working ok

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 48896
Build 45785: arc lint + arc unit

Event Timeline

woodsb02 created this revision.Dec 28 2022, 1:40 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 28 2022, 1:40 AM

woodsb02 requested review of this revision.Dec 28 2022, 1:40 AM

Harbormaster completed remote builds in B48896: Diff 114587.Dec 28 2022, 1:40 AM

It wasn't really clear to me what is changed in the custom dashboard which was previously applied when the CLOUD option was disabled during the FreeBSD port build.

Here is a screenshot with the standard dashboard:
{F53819964}

Here is a screenshot with the custom dashboard:
{F53819967}

Sorry for the delay. LGTM.

I was on a FreeBSD-fast for the past three months so it was hard for me to commit.

This revision is now accepted and ready to land.Dec 28 2022, 2:14 AM

Namkhai B (me@forkbomb9.ch) wants changes. They sent in changes via email to me and you.

I have compared my patch with that provided by Namkhai B. <me@forkbomb9.ch> - they are almost identical (great minds think alike).
A few minor differences outlined below - I'll update the review with the FREEIPMI plist entry added back in. No other changes necessary.

net-mgmt/netdata/pkg-plist
181	For some reason the equivalent patch from Namkhai B. <me@forkbomb9.ch> did not include these additions: lib/netdata/system/netdata-init-d lib/netdata/system/netdata-openrc lib/netdata/system/netdata-updater.service lib/netdata/system/netdata-updater.timer lib/netdata/system/netdata.service lib/netdata/system/netdata.service.v235 libexec/netdata/install-service.sh That said, I think it is correct that these lines are added - otherwise pkg-plist issues will be thrown by poudriere testport.
188	This shouldn't have been deleted - my test builds were done with the FREEIPMI option disabled (default). I noticed this because this deletion was not in the equivalent patch from Namkhai B. <me@forkbomb9.ch>.

Added the FREEIPMI plist entry back in

This revision now requires review to proceed.Dec 28 2022, 5:18 AM

Harbormaster completed remote builds in B48898: Diff 114593.Dec 28 2022, 5:18 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 28 2022, 5:37 AM

Closed by commit R11:14e7c1f66098: net-mgmt/netdata: Update to 1.37.1 (authored by woodsb02). · Explain Why

This revision was automatically updated to reflect the committed changes.

woodsb02 added a commit: R11:14e7c1f66098: net-mgmt/netdata: Update to 1.37.1.

woodsb02 added inline comments.Dec 28 2022, 11:11 PM

net-mgmt/netdata/pkg-plist
181	Response from Namkhai: I think I did not include them as they're irrelevant to freebsd, they're the SystemD and OpenRC scripts, and their installer. But they don't harm, and removing them from pkg-plist is not enough