Page MenuHomeFreeBSD

net-mgmt/netdata: Update to 1.37.1

Authored by woodsb02 on Dec 28 2022, 1:40 AM.
Referenced Files
F61975150: D37889.diff
Mon, May 29, 11:14 AM
Unknown Object (File)
Tue, May 9, 2:39 AM
Unknown Object (File)
Wed, May 3, 3:22 AM
Unknown Object (File)
Apr 9 2023, 8:11 PM
Unknown Object (File)
Apr 9 2023, 8:50 AM
Unknown Object (File)
Apr 7 2023, 2:14 AM
Unknown Object (File)
Apr 5 2023, 7:03 PM
Unknown Object (File)
Apr 5 2023, 7:01 PM



Security: 4b60c3d9-8640-11ed-a762-482ae324f959

Test Plan

poudriere testport - no errors with CLOUD options on or off
Run testing shows the local and cloud dashboards are working ok

Diff Detail

rP FreeBSD ports repository
No Lint Coverage
No Test Coverage
Build Status
Buildable 48896
Build 45785: arc lint + arc unit

Event Timeline

It wasn't really clear to me what is changed in the custom dashboard which was previously applied when the CLOUD option was disabled during the FreeBSD port build.

Here is a screenshot with the standard dashboard:

Here is a screenshot with the custom dashboard:

Sorry for the delay. LGTM.

I was on a FreeBSD-fast for the past three months so it was hard for me to commit.

This revision is now accepted and ready to land.Dec 28 2022, 2:14 AM

Namkhai B ( wants changes. They sent in changes via email to me and you.

I have compared my patch with that provided by Namkhai B. <> - they are almost identical (great minds think alike).
A few minor differences outlined below - I'll update the review with the FREEIPMI plist entry added back in. No other changes necessary.


For some reason the equivalent patch from Namkhai B. <> did not include these additions:


That said, I think it is correct that these lines are added - otherwise pkg-plist issues will be thrown by poudriere testport.


This shouldn't have been deleted - my test builds were done with the FREEIPMI option disabled (default).
I noticed this because this deletion was not in the equivalent patch from Namkhai B. <>.

Added the FREEIPMI plist entry back in

This revision now requires review to proceed.Dec 28 2022, 5:18 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 28 2022, 5:37 AM
This revision was automatically updated to reflect the committed changes.

Response from Namkhai:
I think I did not include them as they're irrelevant to freebsd, they're
the SystemD and OpenRC scripts, and their installer. But they don't harm,
and removing them from pkg-plist is not enough