net-mgmt/netdata: Update to 1.37.1

[woodsb02]

Summary

• Includes fixes for recent streaming security vulnerabilities
• Also remove custom dashboard as a patch for 1.37 wasn't available https://github.com/forkbomb9/netdata

Security: 4b60c3d9-8640-11ed-a762-482ae324f959

Test Plan

poudriere testport - no errors with CLOUD options on or off
Run testing shows the local and cloud dashboards are working ok

[woodsb02]

It wasn't really clear to me what is changed in the custom dashboard which was previously applied when the CLOUD option was disabled during the FreeBSD port build.

Here is a screenshot with the standard dashboard:
{F53819964}

Here is a screenshot with the custom dashboard:
{F53819967}

[nc]

Sorry for the delay. LGTM.

I was on a FreeBSD-fast for the past three months so it was hard for me to commit.

[nc]

Namkhai B ([e-mail]) wants changes. They sent in changes via email to me and you.

[woodsb02]

I have compared my patch with that provided by Namkhai B. <[e-mail]> - they are almost identical (great minds think alike).
A few minor differences outlined below - I'll update the review with the FREEIPMI plist entry added back in. No other changes necessary.

net-mgmt/netdata/pkg-plist

181

For some reason the equivalent patch from Namkhai B. <[e-mail]> did not include these additions:

lib/netdata/system/netdata-init-d
lib/netdata/system/netdata-openrc
lib/netdata/system/netdata-updater.service
lib/netdata/system/netdata-updater.timer
lib/netdata/system/netdata.service
lib/netdata/system/netdata.service.v235
libexec/netdata/install-service.sh

That said, I think it is correct that these lines are added - otherwise pkg-plist issues will be thrown by poudriere testport.

188

This shouldn't have been deleted - my test builds were done with the FREEIPMI option disabled (default).
I noticed this because this deletion was not in the equivalent patch from Namkhai B. <[e-mail]>.

[woodsb02]

Added the FREEIPMI plist entry back in

[woodsb02]

net-mgmt/netdata/pkg-plist

181

Response from Namkhai:
I think I did not include them as they're irrelevant to freebsd, they're
the SystemD and OpenRC scripts, and their installer. But they don't harm,
and removing them from pkg-plist is not enough