Paths

Table of Contentst

Differential D37666

framework: add poppler.mk to depend on poppler-ish ports
Needs ReviewPublic
Actions

Authored by tcberner on Dec 9 2022, 11:08 PM.

Tags

None

Referenced Files

	F166144690: D37666.id114029.diff
	Tue, Aug 11, 11:29 PM

	F166144621: D37666.id114025.diff
	Tue, Aug 11, 11:29 PM

	Unknown Object (File)
	Sun, Aug 9, 11:06 AM

	Unknown Object (File)
	Sat, Aug 8, 1:32 AM

	Unknown Object (File)
	Sun, Aug 2, 6:09 AM

	Unknown Object (File)
	Sun, Aug 2, 5:28 AM

	Unknown Object (File)
	Sun, Aug 2, 4:08 AM

	Unknown Object (File)
	Sun, Aug 2, 2:38 AM

Subscribers

None

Details

Reviewers

mat
bapt

Group Reviewers

portmgr
desktop

Summary

Usage: USES=poppler:ARGS
Valid ARGS: <none>,lib,glib,qt5,qt6,utils,utils_build

for usage by the ports tree:
        <none>: default = lib
        lib:            LIB_DEPEND on graphics/poppler
        glib:           LIB_DEPEND on graphics/poppler-glib     implies lib
        qt5:            LIB_DPEEND on graphics/poppler-qt5      implies lib
        qt6:            LIB_DEPEND on graphics/poppler-qt6      implies lib
        utils:          RUN_DEPEND on graphics/poppler-utils
        utils_build:    BUILD_DEPEND on graphics/poppler-utils
for internal use:
        selfbuild:      only used by graphics/poppler to get _POPPLER_VERSION

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 48697
Build 45583: arc lint + arc unit

Event Timeline

tcberner created this revision.Dec 9 2022, 11:08 PM

Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptDec 9 2022, 11:08 PM

tcberner requested review of this revision.Dec 9 2022, 11:08 PM

Harbormaster completed remote builds in B48688: Diff 114025.Dec 9 2022, 11:08 PM

mat added inline comments.Dec 10 2022, 7:31 AM

Mk/Uses/poppler.mk
27–37	I have a feeling it would be easier to make the implies work by just adding the lib to the ones that need the lib.

tcberner added inline comments.Dec 10 2022, 7:42 AM

Mk/Uses/poppler.mk
27–37	do you mean doing an `.if` here in the mk instead of the shenanigans on line 44, or do you doing explicit `poppler:qt5,lib` in the ports Makefiles?

poppler.mk: remove IMPLIES feature
poppler.mk: update dependencies

Harbormaster completed remote builds in B48690: Diff 114029.Dec 10 2022, 7:59 AM

poppler.mk: fix conversion in math/cantor and print/pdf-tools

Harbormaster completed remote builds in B48691: Diff 114030.Dec 10 2022, 8:37 AM

mat added inline comments.Dec 11 2022, 8:17 AM

Mk/Uses/poppler.mk
27–37	I meant what I proposed in the diff, add `${_POPPLER_lib_LIB_DEPENDS}` to the `_POPPLER_glib_LIB_DEPENDS`, `_POPPLER_qt5_LIB_DEPENDS` and `_POPPLER_qt6_LIB_DEPENDS` variables, no need to spam the ports with the implied dependencies.

poppler.mk: remove IMPLIES feature
poppler.mk: update dependencies
poppler.mk: fix conversion in math/cantor and print/pdf-tools
Revert "poppler.mk: remove IMPLIES feature"
poppler.mk: add implied _lib_ depends via poppler.mk
Revert "poppler.mk: update dependencies"

Harbormaster completed remote builds in B48697: Diff 114051.Dec 11 2022, 3:18 PM

tcberner marked an inline comment as done.Dec 11 2022, 3:19 PM

tcberner added inline comments.

Mk/Uses/poppler.mk
27–37	ok, I think now I got it :D

Two typos, and a simplification.

Mk/Uses/poppler.mk
31
34
41–48

Revision Contents
Changeset List

Path

Size

11 lines

Mk/

Uses/

50 lines

converters/

pdf2djvu/

5 lines

databases/

kbibtex/

4 lines

deskutils/

bookworm/

4 lines

calibre/

4 lines

cfiles/

5 lines

lumina-pdf/

2 lines

recoll/

2 lines

xfce4-tumbler/

2 lines

devel/

efl/

2 lines

kf5-kfilemetadata/

4 lines

editors/

calligra/

4 lines

gummi/

3 lines

kile/

5 lines

libreoffice/

3 lines

setzer/

3 lines

texstudio/

4 lines

texworks/

6 lines

graphics/

atril/

5 lines

diff-pdf/

5 lines

diffpdf/

4 lines

dspdfviewer/

5 lines

engauge-digitizer/

5 lines

epdfview/

3 lines

evince/

3 lines

gdal/

2 lines

geeqie/

2 lines

gegl/

2 lines

gimp-app/

3 lines

graphviz/

2 lines

impressive/

2 lines

inkscape/

3 lines

katarakt/

3 lines

krita/

4 lines

okular/

4 lines

openfx-arena/

4 lines

openscenegraph/

3 lines

osg/

3 lines

osg34/

2 lines

pdf2svg/

4 lines

pdfpc/

3 lines

poppler/

12 lines

pqiv/

2 lines

py-python-poppler-qt5/

3 lines

qcomicbook/

4 lines

sane-backends/

4 lines

tikzit/

4 lines

vips/

2 lines

xournal/

5 lines

xournalpp/

3 lines

yacreader/

6 lines

zathura-pdf-poppler/

3 lines

mail/

claws-mail-pdf_viewer/

4 lines

textmail/

5 lines

math/

cantor/

6 lines

labplot/

5 lines

misc/

tellico/

4 lines

multimedia/

py-mat2/

5 lines

net/

kitinerary/

3 lines

print/

cups-filters/

5 lines

deforaos-pdfviewer/

3 lines

pdf-tools/

6 lines

pdfarranger/

5 lines

qpdfview/

4 lines

scribus-devel/

3 lines

texlive-base/

3 lines

xreader/

2 lines

sysutils/

catfish/

5 lines

tracker-miners/

3 lines

textproc/

pdfgrep/

3 lines

pdfsandwich/

5 lines

py-pdftotext/

4 lines

py-textract/

2 lines

www/

hotcrp/

5 lines

x11-toolkits/

rubygem-poppler/

3 lines

x11/

eaglemode/

2 lines

Diff 114051

CHANGES

Loading...

Mk/Uses/poppler.mk

Loading...

converters/pdf2djvu/Makefile

Loading...

databases/kbibtex/Makefile

Loading...

deskutils/bookworm/Makefile

Loading...

deskutils/calibre/Makefile

Loading...

deskutils/cfiles/Makefile

Loading...

deskutils/lumina-pdf/Makefile

Loading...

deskutils/recoll/Makefile

Loading...

deskutils/xfce4-tumbler/Makefile

Loading...

devel/efl/Makefile

Loading...

devel/kf5-kfilemetadata/Makefile

Loading...

editors/calligra/Makefile

Loading...

editors/gummi/Makefile

Loading...

editors/kile/Makefile

Loading...

editors/libreoffice/Makefile

Loading...

editors/setzer/Makefile

Loading...

editors/texstudio/Makefile

Loading...

editors/texworks/Makefile

Loading...

graphics/atril/Makefile

Loading...

graphics/diff-pdf/Makefile

Loading...

graphics/diffpdf/Makefile

Loading...

graphics/dspdfviewer/Makefile

Loading...

graphics/engauge-digitizer/Makefile

Loading...

graphics/epdfview/Makefile

Loading...

graphics/evince/Makefile

Loading...

graphics/gdal/Makefile

Loading...

graphics/geeqie/Makefile

Loading...

graphics/gegl/Makefile

Loading...

graphics/gimp-app/Makefile

Loading...

graphics/graphviz/Makefile

Loading...

graphics/impressive/Makefile

Loading...

graphics/inkscape/Makefile

Loading...

graphics/katarakt/Makefile

Loading...

graphics/krita/Makefile

Loading...

graphics/okular/Makefile

Loading...

graphics/openfx-arena/Makefile

Loading...

graphics/openscenegraph/Makefile

Loading...

graphics/osg/Makefile

Loading...

graphics/osg34/Makefile

Loading...

graphics/pdf2svg/Makefile

Loading...

graphics/pdfpc/Makefile

Loading...

graphics/poppler/Makefile

Loading...

graphics/pqiv/Makefile

Loading...

graphics/py-python-poppler-qt5/Makefile

Loading...

graphics/qcomicbook/Makefile

Loading...

graphics/sane-backends/Makefile

Loading...

graphics/tikzit/Makefile

Loading...

graphics/vips/Makefile

Loading...

graphics/xournal/Makefile

Loading...

graphics/xournalpp/Makefile

Loading...

graphics/yacreader/Makefile

Loading...

graphics/zathura-pdf-poppler/Makefile

Loading...

mail/claws-mail-pdf_viewer/Makefile

Loading...

mail/textmail/Makefile

Loading...

math/cantor/Makefile

Loading...

math/labplot/Makefile

Loading...

misc/tellico/Makefile

Loading...

multimedia/py-mat2/Makefile

Loading...

net/kitinerary/Makefile

Loading...

print/cups-filters/Makefile

Loading...

print/deforaos-pdfviewer/Makefile

Loading...

print/pdf-tools/Makefile

Loading...

print/pdfarranger/Makefile

Loading...

print/qpdfview/Makefile

Loading...

print/scribus-devel/Makefile

Loading...

print/texlive-base/Makefile

Loading...

print/xreader/Makefile

Loading...

sysutils/catfish/Makefile

Loading...

sysutils/tracker-miners/Makefile

Loading...

textproc/pdfgrep/Makefile

Loading...

textproc/pdfsandwich/Makefile

Loading...

textproc/py-pdftotext/Makefile

Loading...

textproc/py-textract/Makefile

Loading...

www/hotcrp/Makefile

Loading...

x11-toolkits/rubygem-poppler/Makefile

Loading...

x11/eaglemode/Makefile

Loading...