pkgbase: report errors via metalog reader exit status
ClosedPublic
Actions

Authored by emaste on Nov 23 2022, 9:42 PM.

Details

Reviewers

kevans

Group Reviewers

pkgbase

Commits

rG39c9fd8f2beb: pkgbase: report errors via metalog reader exit status
rGf93d92f43d98: pkgbase: report errors via metalog reader exit status

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

I'm a bit of a lua novice, so if there's a canonical way to do this please let me know

kevans added a subscriber: kevans.Nov 23 2022, 9:59 PM

kevans added inline comments.

tools/pkgbase/metalog_reader.lua
89	Drop the assignment, it'll default to `nil` which is a falsey value
159	`return #duperr or #inodeerr`, perhaps

Perhaps more idomatic lua from kevans

emaste added inline comments.Nov 24 2022, 5:52 PM

tools/pkgbase/metalog_reader.lua
159	Or actually `return #duperr > 0 or #inodeerr > 0`

fix truthiness confusion

kevans accepted this revision as: kevans.Nov 25 2022, 3:23 AM

This revision is now accepted and ready to land.Nov 25 2022, 3:23 AM

Closed by commit rGf93d92f43d98: pkgbase: report errors via metalog reader exit status (authored by emaste). · Explain WhyNov 25 2022, 2:15 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGf93d92f43d98: pkgbase: report errors via metalog reader exit status.

Herald added a subscriber: imp. · View Herald TranscriptNov 25 2022, 2:15 PM

emaste added a commit: rG39c9fd8f2beb: pkgbase: report errors via metalog reader exit status.Mar 23 2023, 3:11 PM

Revision Contents
Changeset List

Path

Size

tools/

pkgbase/

metalog_reader.lua

12 lines

Diff 113516

View Options

tools/pkgbase/metalog_reader.lua

pkgbase: report errors via metalog reader exit statusClosedPublicActions