Page MenuHomeFreeBSD

pkgbase: report errors via metalog reader exit status
ClosedPublic

Authored by emaste on Nov 23 2022, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 29 2022, 5:31 AM
Unknown Object (File)
Dec 14 2022, 2:30 AM
Unknown Object (File)
Nov 30 2022, 4:35 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
emaste added a reviewer: pkgbase.

I'm a bit of a lua novice, so if there's a canonical way to do this please let me know

kevans added inline comments.
tools/pkgbase/metalog_reader.lua
89

Drop the assignment, it'll default to nil which is a falsey value

159

return #duperr or #inodeerr, perhaps

Perhaps more idomatic lua from kevans

tools/pkgbase/metalog_reader.lua
159

Or actually return #duperr > 0 or #inodeerr > 0

This revision is now accepted and ready to land.Nov 25 2022, 3:23 AM