Differential D37496

flua: add a chown(2) binding
ClosedPublic
Actions

Authored by bapt on Nov 24 2022, 8:16 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 13, 5:53 PM

	Unknown Object (File)
	Thu, Aug 13, 5:52 PM

	Unknown Object (File)
	Wed, Aug 12, 9:01 PM

	Unknown Object (File)
	Wed, Aug 12, 1:41 AM

	Unknown Object (File)
	Tue, Aug 11, 2:43 PM

	Unknown Object (File)
	Mon, Aug 10, 10:19 AM

	Unknown Object (File)
	Mon, Aug 10, 5:33 AM

	Unknown Object (File)
	Sat, Aug 8, 3:13 AM

Subscribers

Details

Reviewers

kevans
bapt

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48487
Build 45373: arc lint + arc unit

Event Timeline

bapt created this revision.Nov 24 2022, 8:16 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 24 2022, 8:16 AM

bapt requested review of this revision.Nov 24 2022, 8:16 AM

Harbormaster completed remote builds in B48487: Diff 113479.Nov 24 2022, 8:16 AM

bapt added a reviewer: kevans.Nov 24 2022, 8:16 AM

kevans added inline comments.Nov 24 2022, 2:02 PM

libexec/flua/modules/lposix.c
75	The official luaposix interface actually allows 2 or 3 args, nil for either user/group resulting in -1 -- IMO I think we should do the same. It technically also resolves strings if they're passed, though I don't feel as strongly about that.
79	s/2/3/?

almost follow luaposix, just be stricter and report if a user or group
is valid or not.

Harbormaster completed remote builds in B48495: Diff 113493.Nov 24 2022, 2:40 PM

bapt marked 2 inline comments as done.Nov 24 2022, 2:41 PM

bapt accepted this revision.Nov 25 2022, 7:59 AM

This revision is now accepted and ready to land.Nov 25 2022, 7:59 AM

bapt closed this revision.Nov 25 2022, 7:59 AM

Revision Contents
Changeset List

Path

Size

libexec/

flua/

modules/

25 lines

Diff 113479

libexec/flua/modules/lposix.c

Loading...