Paths

Table of Contentst

Differential D37482

pkgbase: report errors via metalog reader exit status
ClosedPublic
Actions

Authored by emaste on Nov 23 2022, 9:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 26, 9:52 PM

	Unknown Object (File)
	Tue, May 14, 2:00 PM

	Unknown Object (File)
	Apr 25 2024, 2:34 PM

	Unknown Object (File)
	Apr 23 2024, 7:47 PM

	Unknown Object (File)
	Apr 18 2024, 2:41 PM

	Unknown Object (File)
	Apr 18 2024, 2:25 AM

	Unknown Object (File)
	Apr 17 2024, 4:50 PM

	Unknown Object (File)
	Mar 15 2024, 11:17 AM

View All 36 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG39c9fd8f2beb: pkgbase: report errors via metalog reader exit status
rGf93d92f43d98: pkgbase: report errors via metalog reader exit status

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

I'm a bit of a lua novice, so if there's a canonical way to do this please let me know

kevans added a subscriber: kevans.Nov 23 2022, 9:59 PM

kevans added inline comments.

tools/pkgbase/metalog_reader.lua
89	Drop the assignment, it'll default to `nil` which is a falsey value
159	`return #duperr or #inodeerr`, perhaps

Perhaps more idomatic lua from kevans

emaste added inline comments.Nov 24 2022, 5:52 PM

tools/pkgbase/metalog_reader.lua
159	Or actually `return #duperr > 0 or #inodeerr > 0`

fix truthiness confusion

kevans accepted this revision as: kevans.Nov 25 2022, 3:23 AM

This revision is now accepted and ready to land.Nov 25 2022, 3:23 AM

Closed by commit rGf93d92f43d98: pkgbase: report errors via metalog reader exit status (authored by emaste). · Explain WhyNov 25 2022, 2:15 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGf93d92f43d98: pkgbase: report errors via metalog reader exit status.

Herald added a subscriber: imp. · View Herald TranscriptNov 25 2022, 2:15 PM

emaste added a commit: rG39c9fd8f2beb: pkgbase: report errors via metalog reader exit status.Mar 23 2023, 3:11 PM

Revision Contents
Changeset List

Path

Size

tools/

pkgbase/

metalog_reader.lua

14 lines

Diff 113460

tools/pkgbase/metalog_reader.lua

Loading...