Don't panic when tasting a disk with sectorsize=0
ClosedPublic
Actions

Authored by asomers on Nov 9 2022, 3:22 AM.

Details

Reviewers

Commits

rG0e86854450b4: Don't panic when tasting a disk with sectorsize=0
rG05d0f4308caa: Don't panic when tasting a disk with sectorsize=0

Summary

This can sometimes happen with broken HDDs.

MFC after: 2 weeks
Sponsored by: Axcient

Test Plan

Manually tested with a suitably broken HDD

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48243
Build 45129: arc lint + arc unit

Event Timeline

asomers created this revision.Nov 9 2022, 3:22 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 9 2022, 3:22 AM

Harbormaster completed remote builds in B48237: Diff 112792.Nov 9 2022, 3:22 AM

asomers requested review of this revision.Nov 9 2022, 3:22 AM

Seems ok, but why not handle it in g_label_taste(), or even at some higher level in GEOM (maybe g_disk_create())? I can't think of any classes that will do something sane with a provider with sectorsize 0...

This revision is now accepted and ready to land.Nov 9 2022, 4:24 PM

In D37313#847880, @markj wrote:

Seems ok, but why not handle it in g_label_taste(), or even at some higher level in GEOM (maybe g_disk_create())? I can't think of any classes that will do something sane with a provider with sectorsize 0...

Ok, I'll move the part from g_label_ufs.c into g_label_taste. I don't want to move it higher up though, because g_label_taste can also be called in the resize path. And I'll leave the changes to the other label classes, because they're 0-cost.