Page MenuHomeFreeBSD
Differential D37263

getty: code cleanup, part 1
ClosedPublic
Actions

Authored by des on Nov 4 2022, 1:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 23, 7:00 AM
Unknown Object (File)
Mon, Mar 23, 1:36 AM
Unknown Object (File)
Sun, Mar 22, 6:36 AM
Unknown Object (File)
Sat, Mar 21, 10:07 AM
Unknown Object (File)
Sat, Mar 21, 10:07 AM
Unknown Object (File)
Wed, Mar 18, 2:25 AM
Unknown Object (File)
Tue, Mar 17, 8:39 PM
Unknown Object (File)
Sun, Mar 15, 6:28 PM
View All Files
Subscribers
allanjude
imp
pstef

Details

Reviewers
allanjude
Group Reviewers
Klara
Commits
rGd488e8d0372d: getty: code cleanup, part 1
rG8ad7a14ab49b: getty: code cleanup, part 1
Summary
  • Avoid unnecessary use of unsigned char *
  • Use explicit casts when assigning unsigned char * to char * or vice versa
  • Drop unused global variables (and fix memory leak in gettable())
  • Use snprintf() instead of strcpy() + strcat()
  • Drop spurious braces in switch

Sponsored by: Klara, Inc.
Obtained from: Apple OSS Distributions (in part)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Nov 4 2022, 1:33 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 4 2022, 1:33 PM
des requested review of this revision.Nov 4 2022, 1:33 PM
Harbormaster completed remote builds in B48143: Diff 112599.Nov 4 2022, 1:33 PM
des added a reviewer: Klara.Nov 4 2022, 1:33 PM
allanjude accepted this revision.Nov 4 2022, 2:01 PM
allanjude added a subscriber: allanjude.

Reviewed by: allanjude

This revision is now accepted and ready to land.Nov 4 2022, 2:01 PM
pstef added a subscriber: pstef.Nov 4 2022, 2:02 PM

If you intend to do more work on these files, I suggest improving the style before introducing more significant changes. There is a lot of inherited stylistic issues here, unfortunately.
I think you have a typo in the description and you meant "braces" - I meantion it just in case you planned to copy it to the commit message.

libexec/getty/chat.c
276

missed opportunity to improve formatting

des updated this revision to Diff 112604.Nov 4 2022, 2:18 PM

Update commit message

This revision now requires review to proceed.Nov 4 2022, 2:18 PM
Harbormaster completed remote builds in B48147: Diff 112604.Nov 4 2022, 2:18 PM
des edited the summary of this revision. (Show Details)Nov 4 2022, 2:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 4 2022, 2:21 PM
Closed by commit rG8ad7a14ab49b: getty: code cleanup, part 1 (authored by des). · Explain Why
This revision was automatically updated to reflect the committed changes.
des added a commit: rG8ad7a14ab49b: getty: code cleanup, part 1.
des added a commit: rGd488e8d0372d: getty: code cleanup, part 1.Nov 14 2022, 11:23 AM

Revision Contents
Changeset List

PathSize
libexec/
getty/
14 lines
2 lines
2 lines
18 lines
16 lines

Diff 112605

View Options

libexec/getty/chat.c

Loading...
View Options

libexec/getty/extern.h

Loading...
View Options

libexec/getty/init.c

Loading...
View Options

libexec/getty/main.c

Loading...
View Options

libexec/getty/subr.c

Loading...