Limit MAXCPU <= MAX_APIC_ID assertion to i386
AbandonedPublic
Actions

Authored by emaste on Oct 19 2022, 7:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jun 5, 10:34 AM

	Unknown Object (File)
	Thu, May 23, 4:33 AM

	Unknown Object (File)
	Apr 26 2024, 4:19 PM

	Unknown Object (File)
	Apr 26 2024, 4:19 PM

	Unknown Object (File)
	Apr 26 2024, 11:01 AM

	Unknown Object (File)
	Apr 24 2024, 10:52 AM

	Unknown Object (File)
	Apr 22 2024, 9:51 AM

	Unknown Object (File)
	Apr 3 2024, 5:16 PM

View All 32 Files

Subscribers

kib

Details

Reviewers

jhb
royger

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

From @jhb in D36838: the assertion about MAXCPU being <= MAX_APIC_ID is no longer relevant with x2APIC and can be removed I think. I'm not sure if we support x2APIC on i386, so maybe the assertion has to stay for i386 still

emaste mentioned this in D36838: amd64: Bump MAXCPU to 1024 (from 256).Oct 19 2022, 7:33 PM

No, MAX_APIC_ID is also relevant for amd64, as it's used by madt_parse_cpu(), it needs to be bumped to twice the value of MAXCPU I think.

I guess you could have a i386 system with APIC IDs > 0x200, but it's unlikely such system doesn't support amd64.

i386 also uses x2APIC when supported by hardware and not disabled by BIOS.

emaste abandoned this revision.Oct 20 2022, 11:57 AM

Revision Contents
Changeset List

Path

Size

sys/

x86/

mp_x86.c

2 lines

Diff 112006

View Options

Limit MAXCPU <= MAX_APIC_ID assertion to i386AbandonedPublicActions