libc: Make elf_aux_info() return an error if AT_USRSTACK* is undefined
ClosedPublic
Actions

Authored by markj on Oct 18 2022, 3:47 PM.

Details

Reviewers

kib
brooks
imp

Commits

rGa4ee0edc4a0b: libc: Make elf_aux_info() return an error if AT_USRSTACK* is undefined

Summary

Otherwise we do not fall back to sysctls if the auxv entries are not
defined by the kernel. Arguably this is not a bug since we do not
support newer libc running on an older kernel, but we can be a bit more
gentle here.

I assume here that the kernel-provided values for AT_USRSTACK* are
always non-zero.

Reported by: Paul Floyd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 18 2022, 3:47 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 18 2022, 3:47 PM

markj requested review of this revision.Oct 18 2022, 3:47 PM

Harbormaster completed remote builds in B47878: Diff 111931.Oct 18 2022, 3:47 PM

markj added reviewers: kib, brooks, imp.Oct 18 2022, 3:48 PM

Ok, timekeep uses the similar check. I wonder should we record the auxv presence in init_aux(), instead.

This revision is now accepted and ready to land.Oct 18 2022, 3:55 PM

brooks accepted this revision.Oct 18 2022, 8:59 PM

Closed by commit rGa4ee0edc4a0b: libc: Make elf_aux_info() return an error if AT_USRSTACK* is undefined (authored by markj). · Explain WhyOct 18 2022, 10:18 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa4ee0edc4a0b: libc: Make elf_aux_info() return an error if AT_USRSTACK* is undefined.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

auxv.c

14 lines

Diff 111940

View Options

libc: Make elf_aux_info() return an error if AT_USRSTACK* is undefinedClosedPublicActions