textproc/fcitx5-qt: Add Qt6 support and split into qt5, qt6, common FLAVORS
ClosedPublic
Actions

Authored by lwhsu on Aug 31 2022, 8:33 PM.

Details

Reviewers

khng
tcberner

Commits

R11:f5d6cd42fc05: textproc/fcitx5-qt*: Add Qt6 support

Summary

I know that the USES in each flavor can be sorted more, but let's check if
this direction makes sense first.

I haven't decided yet that we should bump fcitx5-qt's PORTREVISION to make it
5.0.8_1, or rename qt5 flavor package to fcitx5-qt5 and keep 5.0.8 version.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 47752
Build 44639: arc lint + arc unit

Event Timeline

lwhsu created this revision.Aug 31 2022, 8:33 PM

Herald added a subscriber: mat. · View Herald TranscriptAug 31 2022, 8:33 PM

lwhsu requested review of this revision.Aug 31 2022, 8:33 PM

Harbormaster completed remote builds in B47210: Diff 110025.Aug 31 2022, 8:33 PM

tcberner added inline comments.Aug 31 2022, 9:05 PM

textproc/fcitx5-qt/Makefile
23	^ how about `5` for symmmetry?
29	`CMAKE_OFF=ENABLE_QT4` could be extraced outside the ifs. Also, we don't have Qt4 for years now, so maybe just drop it :)
35	^ I think you should enforce `>=${DISTVERSION}` here, as you want to be in sync most likely