Page MenuHomeFreeBSD
Differential D36880

uart_dev_snps: Fix device probing
ClosedPublic
Actions

Authored by kd on Oct 5 2022, 6:57 AM.
Tags
None
Referenced Files
F166613011: D36880.id111508.diff
Fri, Aug 14, 9:13 PM
F166613010: D36880.id111447.diff
Fri, Aug 14, 9:13 PM
F166613009: D36880.id111446.diff
Fri, Aug 14, 9:13 PM
F166613008: D36880.id.diff
Fri, Aug 14, 9:13 PM
F166612969: D36880.diff
Fri, Aug 14, 9:13 PM
Unknown Object (File)
Sat, Aug 8, 5:47 PM
Unknown Object (File)
Sat, Aug 8, 5:17 PM
Unknown Object (File)
Sat, Aug 8, 5:11 PM
View All Files
Subscribers
imp

Details

Reviewers
mw
manu
Commits
rG6bdc398832a6: uart_dev_snps: Fix device probing
Summary

The "uart_bus_probe" function is used as a generic part of uart probe logic.
It returns a driver priority(negative number) if successful and an error code otherwise.
Fix the error checking condition to account for that.
Also, while here return "BUS_PROBE_VENDOR", instead of "0".




PR: 266657
Diff Detail
Repository 
rG FreeBSD src repository 
Lint 
Lint Not Applicable
 
Unit 
Tests Not Applicable
 
Event Timeline
kd requested review of this revision.Oct 5 2022, 6:57 AM
kd updated this revision to Diff 111447.
kd created this revision.
Fix patch context (-U9999)
mw accepted this revision.Oct 5 2022, 12:26 PM
This revision is now accepted and ready to land.Oct 5 2022, 12:26 PM
Closed by commit rG6bdc398832a6: uart_dev_snps: Fix device probing (authored by kd).  ·  Explain WhyOct 6 2022, 2:53 PM
This revision was automatically updated to reflect the committed changes.
kd added a commit: rG6bdc398832a6: uart_dev_snps: Fix device probing.
Herald added a subscriber: imp.  ·  View Herald TranscriptOct 6 2022, 2:53 PM
Revision Contents
Changeset List
PathSize
sys/
dev/
uart/
4 lines
Diff 111508
View Options
sys/dev/uart/uart_dev_snps.c
Loading...