Differential D36876

riscv: handle misaligned address exceptions
ClosedPublic
Actions

Authored by mhorne on Oct 4 2022, 4:04 PM.

Details

Reviewers

None

Group Reviewers

riscv

Commits

rG97edb6baa910: riscv: handle misaligned address exceptions
rG9b4cbaa9c3da: riscv: handle misaligned address exceptions

Summary

If this exception is coming from userspace, send the appropriate SIGBUS
to the process. If it's coming from the kernel this is still fatal, but
we can give a better panic message.

With this, we now handle all defined exception types.

PR: 266109
Found by: syzkaller
Reported by: P1umer <p1umer1337@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47691
Build 44578: arc lint + arc unit

Event Timeline

mhorne created this revision.Oct 4 2022, 4:04 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 4 2022, 4:04 PM

mhorne requested review of this revision.Oct 4 2022, 4:04 PM

Harbormaster completed remote builds in B47691: Diff 111433.Oct 4 2022, 4:04 PM

In theory these should be impossible[1] because firmware is meant to emulate them when not supported. There's nothing wrong with being prepared to handle cases where they aren't emulated but I'm curious in what situations they occur. Maybe misaligned atomics, which can't be safely emulated?

[1] Except on CHERI, as CHERI capabilities have to be stored at aligned locations, so we have this kind of diff downstream for load/store misaligned from userspace, guarded by whether it's a CHERI kernel

In D36876#837189, @jrtc27 wrote:

In theory these should be impossible[1] because firmware is meant to emulate them when not supported. There's nothing wrong with being prepared to handle cases where they aren't emulated but I'm curious in what situations they occur. Maybe misaligned atomics, which can't be safely emulated?

[1] Except on CHERI, as CHERI capabilities have to be stored at aligned locations, so we have this kind of diff downstream for load/store misaligned from userspace, guarded by whether it's a CHERI kernel

Indeed, misaligned atomics can trigger the panic seen in the report, while normal loads/stores are emulated properly.