Differential D4521

deprecate ofw_bus_search_compatible, replace with ofw_bus_compatible_lookup
Needs ReviewPublic
Actions

Authored by howard0su_gmail.com on Dec 11 2015, 5:36 PM.

Tags

None

Referenced Files

	F137769193: D4521.id11514.diff
	Tue, Nov 25, 4:07 PM

	Unknown Object (File)
	Tue, Nov 25, 6:13 AM

	Unknown Object (File)
	Sun, Nov 23, 3:52 AM

	Unknown Object (File)
	Wed, Nov 19, 12:29 PM

	Unknown Object (File)
	Mon, Nov 17, 11:27 PM

	Unknown Object (File)
	Mon, Nov 17, 5:00 PM

	Unknown Object (File)
	Sat, Nov 8, 1:05 AM

	Unknown Object (File)
	Thu, Nov 6, 12:31 AM

Subscribers

Details

Reviewers

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1586
Build 1592: arc lint + arc unit

Event Timeline

howard0su_gmail.com updated this revision to Diff 11139.Dec 11 2015, 5:36 PM

howard0su_gmail.com retitled this revision from to deprecate ofw_bus_search_compatible, replace with ofw_bus_compatible_lookup.

howard0su_gmail.com updated this object.

howard0su_gmail.com edited the test plan for this revision. (Show Details)

howard0su_gmail.com added a reviewer: imp.

Herald added subscribers: emaste, andrew. · View Herald TranscriptDec 11 2015, 5:36 PM

Generally, this looks good. Not sure which of these we compile as modules, but It's what we need.

sys/arm/freescale/imx/imx_nop_usbphy.c
95	There's no SIMPLEBUS_PNP_INFO in this file.
sys/arm/ti/omap4/omap4_prcm_clks.c
1409	Nit picky: ocd != NULL though I know you don't use it elsewhere...
sys/dev/ffec/if_ffec.c
1729	ditto
sys/dev/uart/uart_bus_fdt.c
100	!= NULL
sys/dev/usb/controller/ehci_imx.c
167	Again, no SIMPLEBUS_PNP_INFO line

Split patch into two patches. this one only contains remove usage of
deprecated function. add pnp_info into a seperate patch.

Address review comments.

Split the change to add PNPINFO to a separate patch.

mark done of the comments.

Revision Contents
Changeset List

Path

Size

sys/

arm/

arm/

3 lines

5 lines

4 lines

3 lines

freescale/

imx/

3 lines

3 lines

3 lines

4 lines

imx_nop_usbphy.c

2 lines

13 lines

3 lines

samsung/

exynos/

5 lines

5 lines

ti/

3 lines

am335x/

am335x_dmtimer.c

3 lines

am335x_dmtpps.c

4 lines

3 lines

omap4/

3 lines

omap4_prcm_clks.c

7 lines

8 lines

2 lines

arm64/

arm64/

3 lines

dev/

ahci/

3 lines

ffec/

11 lines

iicbus/

12 lines

mmc/

host/

7 lines

ofw/

15 lines

16 lines

psci/

8 lines

uart/

4 lines

usb/

controller/

2 lines

Diff 11139

sys/arm/arm/gic.c

Loading...

sys/arm/arm/mpcore_timer.c

Loading...

sys/arm/arm/pl310.c

Loading...

sys/arm/arm/pmu.c

Loading...

sys/arm/freescale/imx/imx_gpio.c

Loading...

sys/arm/freescale/imx/imx_gpt.c

Loading...

sys/arm/freescale/imx/imx_i2c.c

Loading...

sys/arm/freescale/imx/imx_iomux.c

Loading...

sys/arm/freescale/imx/imx_nop_usbphy.c

Loading...

sys/arm/freescale/imx/imx_sdhci.c

Loading...

sys/arm/freescale/imx/imx_wdog.c

Loading...

sys/arm/samsung/exynos/exynos5_pad.c

Loading...

sys/arm/samsung/exynos/exynos5_pmu.c

Loading...

sys/arm/ti/aintc.c

Loading...

sys/arm/ti/am335x/am335x_dmtimer.c

Loading...

sys/arm/ti/am335x/am335x_dmtpps.c

Loading...

sys/arm/ti/am335x/am335x_gpio.c

Loading...

sys/arm/ti/omap4/omap4_gpio.c

Loading...

sys/arm/ti/omap4/omap4_prcm_clks.c

Loading...

sys/arm/ti/ti_adc.c

Loading...

sys/arm/ti/ti_sdhci.c

Loading...

sys/arm64/arm64/gic_fdt.c

Loading...

sys/dev/ahci/ahci_generic.c

Loading...

sys/dev/ffec/if_ffec.c

Loading...

sys/dev/iicbus/icee.c

Loading...

sys/dev/mmc/host/dwmmc.c

Loading...

sys/dev/ofw/ofw_bus_subr.h

Loading...

sys/dev/ofw/ofw_bus_subr.c

Loading...

sys/dev/psci/psci.c

Loading...

sys/dev/uart/uart_bus_fdt.c

Loading...

sys/dev/usb/controller/ehci_imx.c

Loading...