Page MenuHomeFreeBSD
Differential D36141

local_unbound: rc: allow to overwrite pid file path
ClosedPublic
Actions

Authored by bz on Aug 11 2022, 2:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 12, 1:15 AM
Unknown Object (File)
Tue, May 12, 1:15 AM
Unknown Object (File)
Tue, May 12, 1:15 AM
Unknown Object (File)
Tue, May 12, 12:43 AM
Unknown Object (File)
Mon, Apr 27, 10:07 AM
Unknown Object (File)
Fri, Apr 24, 6:47 AM
Unknown Object (File)
Fri, Apr 24, 6:29 AM
Unknown Object (File)
Fri, Apr 24, 6:25 AM
View All Files
Subscribers
0mp
imp

Details

Reviewers
cy
0mp
Group Reviewers
rc
Commits
rGfe67d3255027: local_unbound: rc: allow to overwrite pid file path
rGe19631737085: local_unbound: rc: allow to overwrite pid file path
Summary

Certain configurations need to use a different path for pidfile.
Allow rc.conf to overwrite it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46860
Build 43749: arc lint + arc unit

Event Timeline

bz created this revision.Aug 11 2022, 2:34 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 11 2022, 2:34 PM
bz requested review of this revision.Aug 11 2022, 2:34 PM
Harbormaster completed remote builds in B46860: Diff 109164.Aug 11 2022, 2:34 PM
0mp requested changes to this revision.Aug 19 2022, 9:08 AM
0mp added a subscriber: 0mp.
0mp added inline comments.
libexec/rc/rc.d/local_unbound
37

This should probably be called local_unbound_pidfile for consistency with other services.

This revision now requires changes to proceed.Aug 19 2022, 9:08 AM
bz updated this revision to Diff 109854.Aug 25 2022, 5:34 PM

Rename to _pidfile as requested by @0mp

Harbormaster completed remote builds in B47130: Diff 109854.Aug 25 2022, 5:34 PM
bz marked an inline comment as done.Aug 31 2022, 10:34 PM
cy accepted this revision.Aug 31 2022, 11:03 PM

LGTM

0mp accepted this revision.Sep 1 2022, 4:14 PM
This revision is now accepted and ready to land.Sep 1 2022, 4:14 PM
Closed by commit rGe19631737085: local_unbound: rc: allow to overwrite pid file path (authored by bz). · Explain WhySep 1 2022, 11:54 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rGe19631737085: local_unbound: rc: allow to overwrite pid file path.
bz added a commit: rGfe67d3255027: local_unbound: rc: allow to overwrite pid file path.Sep 21 2022, 2:02 PM

Revision Contents
Changeset List

PathSize
libexec/
rc/
rc.d/
2 lines

Diff 109164

View Options

libexec/rc/rc.d/local_unbound

Loading...