Page MenuHomeFreeBSD
Differential D36099

linuxkpi: Add refcount_dec_and_test
ClosedPublic
Actions

Authored by manu on Aug 10 2022, 6:46 AM.
Tags
None
Referenced Files
F149946006: D36099.id109084.diff
Sat, Mar 28, 7:17 AM
F149945446: D36099.id109084.diff
Sat, Mar 28, 7:11 AM
Unknown Object (File)
Wed, Mar 18, 7:21 PM
Unknown Object (File)
Wed, Mar 18, 6:31 PM
Unknown Object (File)
Mon, Mar 16, 4:30 PM
Unknown Object (File)
Sun, Mar 15, 9:55 AM
Unknown Object (File)
Thu, Mar 5, 5:55 PM
Unknown Object (File)
Thu, Mar 5, 5:54 PM
View All 91 Files
Subscribers
bz
emaste
imp
linuxkpi

Details

Reviewers
bz
Commits
rG37e07609505e: linuxkpi: Add refcount_dec_and_test
rG1a6874e3a411: linuxkpi: Add refcount_dec_and_test
Summary

In Linux this takes a refcount_t argument but in linuxkpi struct kref
uses an atomic_t for the refcount and code in drm directly uses this
function with a kref so use an atomic_t here.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46815
Build 43704: arc lint + arc unit

Event Timeline

manu created this revision.Aug 10 2022, 6:46 AM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptAug 10 2022, 6:46 AM
manu requested review of this revision.Aug 10 2022, 6:46 AM
Harbormaster completed remote builds in B46815: Diff 109084.Aug 10 2022, 6:46 AM
manu added a parent revision: D36098: linuxkpi: Add for_each_sgtable_{sg,page}.Aug 10 2022, 6:46 AM
manu added a child revision: D36100: linuxkpi: Add sched/mm.h.
bz added a subscriber: bz.Aug 10 2022, 3:22 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/refcount.h
85

This may be a silly question, but why don't we fix kref instead to use refcount (now that it exists thanks to you)? Then this shouldn't be a problem here.

manu added inline comments.Aug 10 2022, 3:54 PM
sys/compat/linuxkpi/common/include/linux/refcount.h
85

TBH I haven't tested if this open a big can of worms or not ...

bz accepted this revision.Aug 10 2022, 4:04 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/refcount.h
85

I'll be happy to get this in and defer the answer to the worms for later maybe with an XXX should kref use refcount_t? next to it as well?

This revision is now accepted and ready to land.Aug 10 2022, 4:04 PM
manu added inline comments.Aug 10 2022, 5:45 PM
sys/compat/linuxkpi/common/include/linux/refcount.h
85

Yeah I'll add something in linux/kref.h too.

Closed by commit rG1a6874e3a411: linuxkpi: Add refcount_dec_and_test (authored by manu). · Explain WhyAug 18 2022, 9:11 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG1a6874e3a411: linuxkpi: Add refcount_dec_and_test.
manu added a commit: rG37e07609505e: linuxkpi: Add refcount_dec_and_test.Sep 7 2022, 3:12 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
11 lines

Diff 109084

View Options

sys/compat/linuxkpi/common/include/linux/refcount.h

Loading...