Differential D35936

linuxkpi: atomic: Add atomic_fetch_inc
ClosedPublic
Actions

Authored by manu on Jul 26 2022, 9:30 AM.

Tags

None

Referenced Files

	F84244138: D35936.id108985.diff
	Tue, May 21, 8:52 AM

	Unknown Object (File)
	Sun, May 19, 3:59 AM

	Unknown Object (File)
	Sat, Apr 27, 1:48 AM

	Unknown Object (File)
	Apr 17 2024, 11:12 AM

	Unknown Object (File)
	Feb 3 2024, 4:30 PM

	Unknown Object (File)
	Jan 30 2024, 11:43 AM

	Unknown Object (File)
	Jan 12 2024, 6:51 AM

	Unknown Object (File)
	Dec 23 2023, 4:11 AM

View All 24 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG1dc28d6cc594: linuxkpi: atomic: Add atomic_fetch_inc
rG6be89cc88d63: linuxkpi: atomic: Add atomic_fetch_inc

Summary

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46583
Build 43472: arc lint + arc unit

Event Timeline

manu created this revision.Jul 26 2022, 9:30 AM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptJul 26 2022, 9:30 AM

manu requested review of this revision.Jul 26 2022, 9:30 AM

Harbormaster completed remote builds in B46583: Diff 108537.Jul 26 2022, 9:30 AM

manu added a child revision: D35937: linuxkpi: math.h: Add mul_u64_u32_div and mul_u64_u32_shr.Jul 26 2022, 9:30 AM

manu added a reviewer: linuxkpi.Jul 26 2022, 9:33 AM

• hselasky accepted this revision.Jul 26 2022, 9:36 AM

This revision is now accepted and ready to land.Jul 26 2022, 9:36 AM

• hselasky added inline comments.Jul 26 2022, 9:55 AM

sys/compat/linuxkpi/common/include/asm/atomic.h
58	It might be an idea to add a (int) cast for the return value or create an inline function for this, to avoid problems with clang making assumptions about the return values.

Convert to an inline function

This revision now requires review to proceed.Jul 26 2022, 3:19 PM

Harbormaster completed remote builds in B46593: Diff 108548.Jul 26 2022, 3:19 PM

Extra ()'s, but else looks perfect.

This revision is now accepted and ready to land.Jul 26 2022, 3:58 PM

Closed by commit rG6be89cc88d63: linuxkpi: atomic: Add atomic_fetch_inc (authored by manu). · Explain WhyAug 8 2022, 2:04 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG6be89cc88d63: linuxkpi: atomic: Add atomic_fetch_inc.

manu added a commit: rG1dc28d6cc594: linuxkpi: atomic: Add atomic_fetch_inc.Sep 7 2022, 3:11 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

asm/

1 line

Diff 108537

sys/compat/linuxkpi/common/include/asm/atomic.h

Loading...