Page MenuHomeFreeBSD
Differential D35733

framework: add git-hook to check PORTEPOCH validity
ClosedPublic
Actions

Authored by tcberner on Jul 6 2022, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 14, 8:34 AM
Unknown Object (File)
Thu, May 7, 12:30 AM
Unknown Object (File)
Fri, May 1, 4:19 PM
Unknown Object (File)
Fri, May 1, 11:21 AM
Unknown Object (File)
Fri, May 1, 11:03 AM
Unknown Object (File)
Fri, May 1, 9:50 AM
Unknown Object (File)
Thu, Apr 30, 5:52 PM
Unknown Object (File)
Thu, Apr 30, 5:51 PM
View All Files
Subscribers
mat
rene

Details

Reviewers
bapt
Group Reviewers
portmgr
Commits
R11:5ad46769a81f: framework: add git-hook to check PORTEPOCH validity
Summary
  • checks dropping of PORTEPOCH:

[pre-commit] dropped PORTEPOCH 1 in net/kf5-kdav/Makefile

  • checks it being non-decreasing:

[pre-commit] PORTEPOCH decreasing from 2 to 1 in net-p2p/frost/Makefile

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 46288
Build 43177: arc lint + arc unit

Event Timeline

tcberner created this revision.Jul 6 2022, 4:04 PM
Herald added a subscriber: mat. · View Herald TranscriptJul 6 2022, 4:04 PM
tcberner requested review of this revision.Jul 6 2022, 4:04 PM
Harbormaster completed remote builds in B46288: Diff 107839.Jul 6 2022, 4:04 PM
tcberner retitled this revision from framework: add git-hook to check PORTEPOCH vality to framework: add git-hook to check PORTEPOCH validity.Jul 12 2022, 3:41 PM
rene added a subscriber: rene.Jul 12 2022, 6:26 PM
rene added inline comments.
.hooks/pre-commit.d/check_portepoch
10

How does this check that old_epoch was set?

mat added inline comments.Jul 13 2022, 6:10 AM
.hooks/pre-commit.d/check_portepoch
10

we've had -n/-z for a while now, compounded with @rene 's remark.

tcberner updated this revision to Diff 108370.Jul 20 2022, 4:10 PM
  • use -z and -n
Harbormaster completed remote builds in B46495: Diff 108370.Jul 20 2022, 4:10 PM
tcberner marked an inline comment as done.Jul 20 2022, 4:11 PM
tcberner added inline comments.
.hooks/pre-commit.d/check_portepoch
10

switched to using -n and -z respectively

tcberner marked 2 inline comments as done.Jul 20 2022, 4:11 PM
bapt accepted this revision.Oct 12 2022, 3:29 PM
This revision is now accepted and ready to land.Oct 12 2022, 3:29 PM
Closed by commit R11:5ad46769a81f: framework: add git-hook to check PORTEPOCH validity (authored by tcberner). · Explain WhyNov 11 2022, 8:40 PM
This revision was automatically updated to reflect the committed changes.
tcberner added a commit: R11:5ad46769a81f: framework: add git-hook to check PORTEPOCH validity.

Revision Contents
Changeset List

PathSize
.hooks/
pre-commit.d/
25 lines

Diff 107839

View Options

.hooks/pre-commit.d/check_portepoch

Loading...