Page MenuHomeFreeBSD

ena: Make first_interrupt a uint8_t
ClosedPublic

Authored by markj on Jun 30 2022, 6:56 PM.
Tags
None
Referenced Files
F166614680: D35683.diff
Fri, Aug 14, 9:26 PM
Unknown Object (File)
Thu, Aug 13, 7:54 PM
Unknown Object (File)
Thu, Aug 13, 7:54 PM
Unknown Object (File)
Tue, Aug 11, 8:21 AM
Unknown Object (File)
Tue, Aug 11, 7:14 AM
Unknown Object (File)
Tue, Aug 11, 7:07 AM
Unknown Object (File)
Mon, Aug 10, 12:40 PM
Unknown Object (File)
Sat, Aug 8, 4:27 PM
Subscribers

Details

Summary

Avoid passing vars of type bool to atomic(9) routines. The size of bool
is not fixed by the C standard, even though it's one byte by convention.

This fixes the KASAN and KMSAN builds, which fail because the compiler
refuses to silently cast a _Bool * to a uint8_t * when calling the
atomic(9) interceptors.

Fixes: 0ac122c388d9 ("ena: Use atomic_load/store functions for first_interrupt variable")

Test Plan

build GENERIC-KASAN and GENERIC-KMSAN amd64 kernels

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46216
Build 43105: arc lint + arc unit