Page MenuHomeFreeBSD
Differential D35669

socket: fix listen(2) on an already listening socket
ClosedPublic
Actions

Authored by glebius on Jun 30 2022, 3:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 20, 6:41 AM
Unknown Object (File)
Fri, Jul 17, 7:29 AM
Unknown Object (File)
Wed, Jul 15, 2:53 PM
Unknown Object (File)
Tue, Jul 14, 10:26 PM
Unknown Object (File)
May 18 2026, 1:27 AM
Unknown Object (File)
May 18 2026, 1:22 AM
Unknown Object (File)
May 14 2026, 10:31 AM
Unknown Object (File)
May 13 2026, 8:15 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
Commits
rG66c8e3fccf0c: socket: fix listen(2) on an already listening socket
Summary

Fixes: 141fe2dceeaeefaaffc2242c8652345a081e825a

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46192
Build 43081: arc lint + arc unit

Event Timeline

glebius created this revision.Jun 30 2022, 3:15 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 30 2022, 3:15 AM
glebius requested review of this revision.Jun 30 2022, 3:15 AM
Harbormaster completed remote builds in B46192: Diff 107575.Jun 30 2022, 3:15 AM
markj accepted this revision.Jun 30 2022, 2:33 PM

Oops, thanks.

Will you add a test case? I'll write one if not.

This revision is now accepted and ready to land.Jun 30 2022, 2:33 PM
glebius added a comment.Jun 30 2022, 2:49 PM
In D35669#808847, @markj wrote:

Oops, thanks.

Will you add a test case? I'll write one if not.

A proper one, that would not only check that syscall didn't fail, but would also exercise the backlog, would require some time. I can't promise one soon. Feel free to write & commit yours. If I start working on a test, I will message you, so we don't do same work.

Closed by commit rG66c8e3fccf0c: socket: fix listen(2) on an already listening socket (authored by glebius). · Explain WhyJun 30 2022, 2:50 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG66c8e3fccf0c: socket: fix listen(2) on an already listening socket.

Revision Contents
Changeset List

PathSize
sys/
kern/
5 lines

Diff 107575

View Options

sys/kern/uipc_socket.c

Loading...