Page MenuHomeFreeBSD

truss: Make control message header parsing more robust
ClosedPublic

Authored by markj on Jun 13 2022, 9:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 8, 2:21 AM
Unknown Object (File)
Sun, Sep 6, 2:37 PM
Unknown Object (File)
Sat, Sep 5, 6:29 PM
Unknown Object (File)
Sat, Sep 5, 2:56 PM
Unknown Object (File)
Sat, Sep 5, 4:14 AM
Unknown Object (File)
Fri, Sep 4, 8:06 AM
Unknown Object (File)
Fri, Sep 4, 3:57 AM
Unknown Object (File)
Thu, Sep 3, 3:01 PM
Subscribers

Details

Summary

print_cmsg() was assuming that the control message chain is well-formed,
but that isn't necessarily the case for sendmsg(2). In particular, if
cmsg_len is zero, print_cmsg() will loop forever. Check for truncated
headers and try to recover if possible.

Test Plan

This was found by running a syzkaller reproducer under truss. Now it prints:

94908: sendmsg(3,{NULL,0,0x0,0,{{level=SOL_SOCKET,type=SCM_RIGHTS,data={}}{<invalid cmsg len=0>}},108,0},0) ERR#22 'Invalid argument'

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45963
Build 42851: arc lint + arc unit