Page MenuHomeFreeBSD

cleanup: remove expired versions of OpenJDK (12 through 16)
ClosedPublic

Authored by rene on May 21 2022, 2:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 2:36 AM
Unknown Object (File)
Fri, Mar 15, 3:00 PM
Unknown Object (File)
Thu, Mar 14, 2:48 PM
Unknown Object (File)
Thu, Mar 14, 2:47 PM
Unknown Object (File)
Thu, Mar 14, 2:44 PM
Unknown Object (File)
Mon, Mar 11, 2:39 AM
Unknown Object (File)
Mon, Mar 11, 2:37 AM
Unknown Object (File)
Mon, Mar 11, 2:33 AM
Subscribers

Details

Summary

Adjust ports depending on expired versions of OpenJDK:

  • biology/snpeff: 12+ -> 11+
  • devel/RStudio: 12 -> 11
  • www/closure-compiler: 13 -> 11+

Allow java/openjdk17 to use java/openjdk17-bootstrap on i386
too, this builds just fine on 13.1-i386

Remove jdk12-doc as it is no longer relevant.

Clean up Java version calculations in bsd.java.mk

Test Plan

make index

build java/openjdk17 on i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 45695
Build 42583: arc lint + arc unit

Event Timeline

rene requested review of this revision.May 21 2022, 2:58 PM
rene edited the test plan for this revision. (Show Details)

note to self: don't forget to update MOVED

  • Add MOVED lines and update bsd.default-versions.mk

The SnpEff site clearly states a Java 12 requirement: http://pcingola.github.io/SnpEff/

So I think this will have to go to 17+.

  • biology/snpeff: use Java 17 or later.

Looks good to me. I had some minor optional comments. Thanks for doing this René!

MOVED
17175–17179

This is true for 12, 14, and 16. While Oracle no longer release updates for 13 and 15, the repositories are getting back/forward ports of security fixes. I believe this is being done by Azul Systems. The FreeBSD ports have been following these updates as well, in general. That said, I don't get the feeling that they are being used by anyone and they are not official LTS releases. We'd also need some way to bootstrap them if we were to keep them since all of these releases need bootstrapping by the previous version. So I think it is the right thing to do to remove them.

java/openjdk17/Makefile
114–115

This conditional seems like it should just be deleted given that openjdk16 is being removed and be collapsed into the line above:

BOOTSTRAP_JDKS= ${LOCALBASE}/openjdk17 ${LOCALBASE}/bootstrap-openjdk17

125–128

Can we just delete this inner conditional now? It seems like it is pretty much covered by ONLY_FOR_ARCHS

rene marked 3 inline comments as done.May 24 2022, 7:35 PM
rene added inline comments.
java/openjdk17/Makefile
125–128

Sure, I wasn't sure if there was some edge case left.

rene marked an inline comment as done.
  • java/openjdk17: simplify bootstrap logic

Self-accept to close.

This revision is now accepted and ready to land.May 24 2022, 9:17 PM